Added fonts locally and configured them with webpack #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good : ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Added fonts locally and configured them with webpack.
Added
font-displayproperty so text is diplayed using fallback font while fonts are being downloaded.Removed Google Font API from the index.html
Benefits
Fonts now are served through http2 which is much faster than using Google fonts API.
Fonts now leverage the
font-displayproperty which makes text use fallback font even when fonts are downloading. Greatly improves user experience when browsing through slow internet connection. Learn moreVerification Process
Verified that fonts do use a fallback font using browser developer tools to simulate a Slow 3G connection. Web app is fucntioning as expected in Firefox and Chrome both.
Applicable Issues
Closes #22