Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boilerplate config for testing #134

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

boilerplate config for testing #134

wants to merge 1 commit into from

Conversation

nik72619c
Copy link
Member

No description provided.

@nik72619c nik72619c requested a review from alexdor March 23, 2019 14:11
@alexdor alexdor mentioned this pull request Mar 25, 2019
Open
alexdor
alexdor requested changes Mar 25, 2019
View reviewed changes
Copy link
Member

@alexdor alexdor left a comment •
edited by nik72619c
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the pr with the following:

  • Delete package-lock.json and update the yarn.lock with the new dependencies

src/App.test.tsx
@@ -1,9 +0,0 @@
import React from "react";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add this file back?

src/__tests__/App.test.js
@@ -0,0 +1,9 @@
import React from 'react';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why js instead of ts?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added js because I dont think I would be writing typescript in my tests. But anyways, i'll make it a ts file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexdor alexdor alexdor requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nik72619c @alexdor