False positives for object values in sort-array-values rule (#155)

ota-meshi · Feb 17, 2022 · 362c2c9 · 362c2c9
1 parent 0308b7a
commit 362c2c9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/rules/sort-array-values.ts b/lib/rules/sort-array-values.ts
@@ -163,7 +163,8 @@ function buildValidatorFromType(
         if (typeof a.value === "string" && typeof b.value === "string") {
             return compareText([a.value, b.value])
         }
-        if (getJSONPrimitiveType(a.value) === getJSONPrimitiveType(b.value)) {
+        const type = getJSONPrimitiveType(a.value)
+        if (type && type === getJSONPrimitiveType(b.value)) {
             return compareValue([a.value, b.value])
         }
         // Unknown

diff --git a/tests/lib/rules/sort-array-values.ts b/tests/lib/rules/sort-array-values.ts
@@ -48,6 +48,10 @@ tester.run("sort-array-values", rule as any, {
                 },
             ],
         },
+        {
+            code: '{"key": [["b"], ["a"], "c"] }',
+            options: [{ pathPattern: "^key$", order: { type: "asc" } }],
+        },
     ],
     invalid: [
         {
-Original file line number
+Diff line change
@@ Expand Up / @@ -48,6 +48,10 @@ tester.run("sort-array-values", rule as any, { @@
                     },
                 ],
             },
+            {
+                code: '{"key": [["b"], ["a"], "c"] }',
+                options: [{ pathPattern: "^key$", order: { type: "asc" } }],
+            },
         ],
         invalid: [
             {
@@ Expand Down @@