Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue139 #141

Merged
merged 4 commits into from
Jun 24, 2020
Merged

Issue139 #141

merged 4 commits into from
Jun 24, 2020

Conversation

calvinjuarez
Copy link
Contributor

@calvinjuarez calvinjuarez commented Jun 23, 2020

This PR also adds an editorconfig file which I added so that my editor would match your indent style by default, but I can remove that if you'd prefer.

My fix also just tries lowercase if the key from the AST doesn't exist, but if this is too broad, I can add a special case just for viewBox. There are other camelCase attributes in SVG, though, so I figured I'd go for broader rather than narrower.

A further option would be to set a list of camelCase SVG attributes and only try lowercase for those attributes. See https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute

See also htmlhint/HTMLHint#28, htmlhint/HTMLHint#183

This could also totally be a bug to open against parse5 instead.

UPDATE: I opened a bug with parse5 (inikulin/parse5#318), so if they choose to fix that, this fix will become obsolete.

@coveralls
Copy link

coveralls commented Jun 23, 2020

Pull Request Test Coverage Report for Build bf373130ee5fff486838cff886ea150d88562656-PR-141

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 96.112%

Totals Coverage Status
Change from base Build 71c463328e9f7de8c63cbed926da8f94035eff80: 0.002%
Covered Lines: 2895
Relevant Lines: 2969

💛 - Coveralls

@ota-meshi
Copy link
Owner

Thank you very much for this PR!

I would like to release this after the work.

@ota-meshi ota-meshi merged commit 836f07d into ota-meshi:master Jun 24, 2020
@ota-meshi
Copy link
Owner

@calvinjuarez v0.19.0 has been released. Thank you!

@calvinjuarez
Copy link
Contributor Author

Awesome! Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants