net.connect issue with Node.js 7.10.0 #109
Comments
watson
changed the title
|
The work to fix this have now been moved to nodejs/node#12861 |
watson
added a commit
to watson/async-listener
that referenced
this issue
Jun 15, 2017
Because issue othiym23#109 have not yet been solved for Node.js 7, the test suite currently fails when running on the latest version of Node.js 7 (v7.10.0 as of this commit). This commit allows 7.x to fail, but adds an extra build for 7.9.0 which is know to be good. This should be reverted when/if Node.js 7 is patched accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A commit recently landed in Node core that was released as v7.10.0 two days ago.
It breaks async-listener because
net.connectno longer callsSocket.prototype.connect. Furthermore, it's not possible to simply monkey-patchnet.connectbecause it's being called internally in node by simply referencing theconnectfunction and not theexports.connectfunction.I'm working on fixing this together with @cjihrig and @jasnell. See nodejs/node#12852 for details.
It will most likely be released as v7.10.1.
The text was updated successfully, but these errors were encountered: