update argument management in net.Socket.prototype.connect to handle node 8 #110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with node v8.0.0-rc.0.
The signature of net._normalizeArgs has been changed in node core. I belive it leads to an issue in async-listner:
I have been having issue while performing http request from a process where the CLS in instanciated (https://gist.github.com/vdeturckheim/5d96705298a55a90a25716314edd449e).
This change fixes my issue and fixes the tests of async-listener with node v8.0.0-rc.0.
CC @joyeecheung @mcollina @jasnell