Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: [email protected] #126

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sabakugaara
Copy link

this will fix net events test case

this will fix net events test case
@sabakugaara
Copy link
Author

@othiym23 CI has passed now, related PR: othiym23/async-listener#129

Please if ok, publish a new version, thank you very much!

@othiym23
Copy link
Owner

Why is this PR necessary? The current semver range (async-listener@^0.6.0) will automatically pick up [email protected] upon a fresh install. Is there a particular reason to pin the dependency?

@sabakugaara
Copy link
Author

Aha, thank you for your remind: it does't need to publish a new version.
It looks like only ci test need this PR.

@sabakugaara
Copy link
Author

@othiym23 Hi, I think this PR should be merged. So other contributor can rely on CI test.

If any thoughts, expect reply~ ^_^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants