Add GitHub Workflow for Rust Checks #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![nero-alpha[bot]](https://avatars.githubusercontent.com/in/808083?s=60&v=4){kind=small}
Establishes a CI workflow for Rust. It includes running tests, enforcing code formatting with `cargo fmt`, and linting with `clippy`. This ensures all pushed code and PRs against main comply with these quality checks.
gvidon
requested changes
Apr 18, 2024
| toolchain: stable | ||
| override: true | ||
| - name: Run tests | ||
| run: cargo test --all |
There was a problem hiding this comment.
For some reason GitHub workflow (for test/format/clippy) fails with such error:
error: could not find `Cargo.toml` in `/home/runner/work/.github/.github` or any parent directory
Resolved the GitHub Actions workflow issue where `Cargo.toml` was not found by adjusting the working directory before executing `cargo` commands. This fix ensures that the `cargo test`, `cargo fmt`, and `cargo clippy` commands are run from the correct directory, thus eliminating the `Cargo.toml` not found error.
|
Changes were made successfully in 1 files |
gvidon
requested changes
Apr 18, 2024
.github/workflows/rust_checks.yml
Outdated
| - name: Run tests | ||
| run: | | ||
| cd .. # Move up from the .github directory to find the workspace root | ||
| cargo test --all |
There was a problem hiding this comment.
All jobs are still failing, but this time with a little different error message:
error: could not find `Cargo.toml` in `/home/runner/work/.github` or any parent directory
The commit fixes the issue where Cargo commands failed to locate the `Cargo.toml` by setting the working directory explicitly to `${{github.workspace}}` for test, format, and clippy jobs in the Rust checks CI workflow.
|
Changes were made successfully in 1 files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linear Issue NRO-6
What has been done
Add GitHub Workflow for Rust Checks
This pull request introduces a new GitHub workflow for automatic Rust checks on pushes and pull requests to the
mainbranch. The checks include running tests, verifying code format withcargo fmt, and linting the codebase withcargo clippy. These checks are essential for maintaining code quality and ensuring that new contributions adhere to the established coding standards.Key changes include:
.github/workflows/rust_checks.ymlto define the workflow.mainbranch.This setup ensures that all contributions are tested, well-formatted, and free of common mistakes or anti-patterns, thus maintaining the high quality of the codebase.
Changes summary
Files changed: 1
Files processed: 1