Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-6862 Use official example domain #4987

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SekoiaTree
Copy link

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-6862

Purpose

Minor help document change: replace a "fake" domain with the official IANA example domain (and use https)

I also did a quick search for other incorrect example URLs. I didn't find any public ones, though I did find

archivist: archivist.login,
works: [
{ external_author_name: "bar",
external_author_email: "[email protected]",
chapter_urls: ["http://foo"] }

but since that's just a test, probably fine. Also, a good amount of http (not s) links, but those mostly get redirected to HTTPS by modern browsers anyhow.

https://github.com/otwcode/otwarchive/blob/6a471a1447cedbed74c9090c5d0f11669a599914/features/fixtures/external_works.yml

also references external domains, but since the point of the test is to make sure that external imports work...

Testing Instructions

Look at the help page at https://test.archiveofourown.org/help/skins-creating.html (replace with localhost as appropriate) and see that it now uses example.com.

References

Not that I know of.

Credit

Sekoia, she/her. Jira account uses the same name.

Copy link
Member

@brianjaustin brianjaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Sekoia, and thank you for the PR!

Everything looks good to me, so I've approved it. Once this is added to the next release, we'll merge the PR and send the changes through QA.

I've assigned the Jira issue to you and set its status to In Review so no one will mistakenly create a duplicate pull request. I've also given your account permission to comment on, assign, and transition issues in the future.

Thanks again for contributing! If you have any questions, you can contact us at [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants