AO3-6862 Use official example domain #4987
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing
)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-6862
Purpose
Minor help document change: replace a "fake" domain with the official IANA example domain (and use https)
I also did a quick search for other incorrect example URLs. I didn't find any public ones, though I did find
otwarchive/spec/controllers/api/v2/api_works_spec.rb
Lines 21 to 25 in 6a471a1
but since that's just a test, probably fine. Also, a good amount of http (not s) links, but those mostly get redirected to HTTPS by modern browsers anyhow.
https://github.com/otwcode/otwarchive/blob/6a471a1447cedbed74c9090c5d0f11669a599914/features/fixtures/external_works.yml
also references external domains, but since the point of the test is to make sure that external imports work...
Testing Instructions
Look at the help page at https://test.archiveofourown.org/help/skins-creating.html (replace with localhost as appropriate) and see that it now uses example.com.
References
Not that I know of.
Credit
Sekoia, she/her. Jira account uses the same name.