AO3-6450 Exclude hidden/unrevealed tags from bins #5006
+129
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarken
reviewed
Jan 3, 2025
sarken
reviewed
Jan 3, 2025
sarken
approved these changes
Jan 6, 2025
|
This is already approved, but I think it would still be nice to have a feature test that tests a specific tag in bins for a tag on a work that is unrevealed and then re-revealed and hidden and then unhidden. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Bonus from reviews on 4967, 4972
Issue
https://otwarchive.atlassian.net/browse/AO3-6450
Purpose
Exclude tags that are only used on unrevealed or admin-hidden works
Includes a post-deploy rake task