Improve output of AttributeSpec to accept CodeBlocks. #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnkoutso
force-pushed
the
constant_context
branch
4 times, most recently
from
23c1e8b to
23f62e9
Compare
oldergod
previously approved these changes
Dec 11, 2023
dnkoutso
force-pushed
the
constant_context
branch
3 times, most recently
from
095a2a9 to
05896fc
Compare
oldergod
previously approved these changes
Dec 11, 2023
dnkoutso
force-pushed
the
constant_context
branch
from
05896fc to
033693a
Compare
dnkoutso
force-pushed
the
constant_context
branch
from
033693a to
5898c2b
Compare
lickel
approved these changes
Dec 11, 2023
oldergod
approved these changes
Dec 12, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago this PR was opened #86 to better handle escaping of strings within attributes.
For Wire we added this temporary commit square/wire@08836c7 to circumvent this issue until a new release of SwiftPoet is ready.
This PR here extends #86 to further use some of the newly added booleans in the Util methods. In particular,
AttributeSpecnow accepts code blocks to properly format strings etc.This means that in Wire we can delete the above commit and lean on SwiftPoet to do the right thing. The PR also brings some tests present in KotlinPoet.