Add wrap_command and docker compose v2 support #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryansch
commented
Oct 29, 2020
morganick
reviewed
Nov 3, 2020
| # If there are any prebuilts, we need to generate an override docker-compose file | ||
| if [[ ${#prebuilt_services[@]} -gt 0 ]] ; then | ||
| echo "~~~ :docker: Creating docker-compose override file for prebuilt services" | ||
| build_image_override_file "${prebuilt_service_overrides[@]}" | tee "$override_file" |
tests/wrap_command.bats
Outdated
| load '../lib/run' | ||
| load '../lib/wrap_command' | ||
|
|
||
| # export DOCKER_COMPOSE_STUB_DEBUG=/dev/tty |
There was a problem hiding this comment.
I'm guessing this is for debugging?
There was a problem hiding this comment.
Yes, all of the specs in this repo keep those lines for debugging failures.
tests/wrap_command.bats
Outdated
| export BUILDKITE_PLUGIN_DOCKER_COMPOSE_CLEANUP=false | ||
|
|
||
| stub docker-compose \ | ||
| "-f docker-compose.yml -p buildkite1111 build --pull myservice : echo built myservice" \ |
There was a problem hiding this comment.
Is -p just the name of the container?
There was a problem hiding this comment.
-p is the name of the docker compose project
morganick
approved these changes
Nov 3, 2020
morganick
approved these changes
Dec 22, 2020
|
@ryansch this has already been approved |
These files need to be renamed to indicate intent at some point.
ryansch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--parallelas it has no effectI still need to add support for the new default
compose.ymlconfig file.