Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make receiving data over TCP faster on Windows #10191

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

Windows has a secret 0.5s delay when the TCP PUSH bit is not set by the sender

http://smallvoid.com/article/winnt-tcp-push-flag.html

How did you verify your code works?

Before, bun upgrade seemed to take a really long time waiting for 0.5s & doing nothing

now it does not

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

@Jarred-Sumner Jarred-Sumner merged commit d00b5b9 into main Apr 12, 2024
27 of 32 checks passed
@Jarred-Sumner Jarred-Sumner deleted the jarred/faster-tcp branch April 12, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant