Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node:child_process: fix propagation of windowsHide and windowsVerbatimArguments option #10193

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

nektro
Copy link
Contributor

@nektro nektro commented Apr 12, 2024

Fixes #10025

@nektro
Copy link
Contributor Author

nektro commented Apr 12, 2024

test result on bun 1.1.3

error: expect(received).toEqual(expected)

  [
    "tasklist",
    "/FI",
+   "\"IMAGENAME",
+   "eq",
+   "chrome.exe\""
-   "IMAGENAME eq chrome.exe"
  ]

- Expected  - 1
+ Received  + 3

      at C:\bun\test\js\node\child_process\child-process-exec.test.ts:105:3
✗ exec with verbatim arguments [54.97ms]

@nektro
Copy link
Contributor Author

nektro commented Apr 12, 2024

test code from the issue on this branch

PS C:\bun> bun-debug.exe .\test.js
[ "C:\\Windows\\system32\\cmd.exe", "/d", "/s", "/c", "\"tasklist /FI \"IMAGENAME eq chrome.exe\"\""
]
INFO: No tasks are running which match the specified criteria.

Copy link
Contributor

Copy link
Contributor

@nektro 1 files with test failures on bun-darwin-aarch64:

View test output

#dd6fcf763f58b27ab3a908205eeb644f685adec8

Copy link
Contributor

@Jarred-Sumner Jarred-Sumner merged commit 7d673dd into main Apr 12, 2024
27 of 33 checks passed
@Jarred-Sumner Jarred-Sumner deleted the nektro-patch-51328 branch April 12, 2024 03:24
cirospaciari pushed a commit that referenced this pull request Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exec and execSync do not properly parse the given string command (tested only on Windows)
2 participants