Use callbacks instead of a promise that calls a callback for node:fs functions that expect callbacks #14109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes a hypothetical execution-order bug in node:fs
Callbacks run before promises.
Since all the node:fs callback functions are currently implemented as wrappers around promises, that means we're delaying execution to the end of the current task. Since these are top-level tasks it should normally not make a difference, but in theory - maybe it could?
This works by making the API for callback-taking functions the same as promise-taking functions and then we don't need to care which is which most of the time
How did you verify your code works?
Untested, but wrote most of the code. Probably doesn't compile.