New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix small leak in node:process.execArgv getter #14154

Merged

Jarred-Sumner merged 1 commit into main from nektro-patch-51921

Sep 27, 2024

Contributor

nektro commented Sep 25, 2024

this getter is cached so the blast radius is small but this patch still frees up the stray bun.String instances created during the initial call


          fix small leak in node:process.execArgv getter

04abc7a

robobun commented Sep 25, 2024 •

edited

Loading

❌ @nektro, your commit 04abc7a has 9 failures in #3893:

test/js/web/fetch/fetch-leak.test.ts - 1 failing on 🪟 x64-baseline

test/js/web/fetch/fetch.test.ts - 1 failing on 🍎 14 aarch64

test/integration/next-pages/test/next-build.test.ts - 1 failing on 🍎 14 aarch64

test/cli/hot/watch.test.ts - 1 failing on 🪟 x64

test/cli/hot/watch.test.ts - 1 failing on 🪟 x64-baseline

test/js/bun/http/fetch-file-upload.test.ts - 1 failing on 🪟 x64

test/cli/watch/watch.test.ts - 2 failing on 🪟 x64-baseline

test/cli/watch/watch.test.ts - 2 failing on 🪟 x64

test/js/node/watch/fs.watch.test.ts - 2 failing on 🍎 14 aarch64

test/js/bun/test/mock/mock-module.test.ts - segmentation fault on 🍎 14 aarch64

test/js/bun/http/bun-serve-static.test.ts - 1 failing on 🍎 14 aarch64

test/js/bun/http/bun-serve-static.test.ts - timeout on 🍎 13 aarch64

nektro marked this pull request as ready for review

September 25, 2024 10:34

Jarred-Sumner merged commit 69d33bb into main

41 of 43 checks passed

Jarred-Sumner deleted the nektro-patch-51921 branch

September 27, 2024 00:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet