Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Use toolchain with dependencies #14166

Merged
merged 12 commits into from
Oct 1, 2024
Merged

cmake: Use toolchain with dependencies #14166

merged 12 commits into from
Oct 1, 2024

Conversation

Electroid
Copy link
Contributor

What does this PR do?

This changes how dependencies are built to use a toolchain file, instead of the previous method, which was error-prone.

@robobun
Copy link

robobun commented Sep 25, 2024

@Electroid, your commit 9b68dfc has 15 failures in #4182:

  • test/js/web/streams/streams.test.js - 2 failing on 🐧 20.04 x64
  • test/js/web/streams/streams.test.js - 2 failing on 🐧 12 x64
  • test/js/web/streams/streams.test.js - 2 failing on 🐧 22.04 x64
  • test/js/web/streams/streams.test.js - 1 failing on 🍎 13 x64
  • test/js/web/streams/streams.test.js - 2 failing on 🐧 22.04 x64-baseline
  • test/js/web/streams/streams.test.js - 2 failing on 🐧 12 x64-baseline
  • test/js/web/streams/streams.test.js - 2 failing on 🐧 20.04 x64-baseline
  • test/js/web/fetch/body-stream.test.ts - 2542 failing on 🐧 20.04 x64
  • test/js/web/fetch/body-stream.test.ts - 2542 failing on 🐧 12 x64
  • test/js/web/fetch/body-stream.test.ts - 2542 failing on 🐧 22.04 x64
  • test/js/web/fetch/body-stream.test.ts - 2542 failing on 🐧 20.04 x64-baseline
  • test/js/web/fetch/body-stream.test.ts - 2542 failing on 🐧 22.04 x64-baseline
  • test/js/web/fetch/body-stream.test.ts - 2542 failing on 🐧 12 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-add-file-with-url.test.js - 1 failing on 🍎 14 aarch64
  • test/js/web/fetch/body-clone.test.ts - 11 failing on 🐧 12 x64
  • test/js/web/fetch/body-clone.test.ts - 11 failing on 🐧 20.04 x64
  • test/js/web/fetch/body-clone.test.ts - 11 failing on 🐧 22.04 x64
  • test/js/web/fetch/body-clone.test.ts - 11 failing on 🐧 22.04 x64-baseline
  • test/js/web/fetch/body-clone.test.ts - 11 failing on 🐧 20.04 x64-baseline
  • test/js/web/fetch/body-clone.test.ts - 11 failing on 🐧 12 x64-baseline
  • test/js/bun/http/serve-body-leak.test.ts - 1 failing on 🍎 14 aarch64
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🍎 14 aarch64
  • test/cli/run/run-crash-handler.test.ts - timeout on 🪟 x64-baseline
  • test/cli/run/run-crash-handler.test.ts - timeout on 🪟 x64
  • test/js/web/fetch/fetch-tcp-stress.test.ts - timeout on 🍎 13 aarch64
  • test/js/web/fetch/fetch-tcp-stress.test.ts - timeout on 🍎 14 aarch64
  • test/js/node/watch/fs.watch.test.ts - 1 failing on 🍎 14 aarch64
  • test/js/node/watch/fs.watch.test.ts - 3 failing on 🍎 13 aarch64
  • test/js/node/watch/fs.watch.test.ts - 1 failing on 🍎 14 x64
  • test/js/bun/http/fetch-file-upload.test.ts - 1 failing on 🪟 x64
  • test/cli/hot/watch.test.ts - 2 failing on 🪟 x64-baseline
  • test/js/node/test/parallel/child-process-exec-timeout-kill.test.js - 1 failing on 🍎 14 aarch64
  • test/js/bun/http/bun-serve-static.test.ts - annotation error on 🍎 13 aarch64
  • test/cli/watch/watch.test.ts - 2 failing on 🪟 x64-baseline
  • test/cli/watch/watch.test.ts - 2 failing on 🪟 x64
  • test/js/bun/http/bun-serve-static.test.ts - 8 failing on 🍎 14 aarch64
  • @Electroid Electroid merged commit 98e09ef into main Oct 1, 2024
    18 of 27 checks passed
    @Electroid Electroid deleted the cmake-fixes branch October 1, 2024 22:38
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants