use bun.String.static instead of ZigString when immediately converting to JSValue #14169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thankfully this wasnt used as much as i was expecting but this should save all of these instances from having an unnecessary
JSC.ZigString
instance in.rodata
as well as aZigString.static
generic instantiation in.text
.found with
ZigString.static\("([^"]+)"\).toJS
andZigString.init\("([^"]+)"\).toJS
being replaced with
bun.String.static("$1").toJS
future work: add support for this in the linter so new instances dont make their way in