enhance INVALID_ARG_TYPE and cleanup some node:buffer error handling #14200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylan-conway
reviewed
Oct 3, 2024
| throwNodeRangeError(lexicalGlobalObject, scope, "Invalid array length"_s); | ||
| else | ||
| throwTypeError(lexicalGlobalObject, scope, "Expected number"_s); | ||
| const unsigned U32_MAX = std::numeric_limits<unsigned>().max(); |
dylan-conway
reviewed
Oct 3, 2024
| auto num = arg.asNumber(); | ||
| if (num < 0 || std::isinf(num)) return Bun::ERR::OUT_OF_RANGE(scope, lexicalGlobalObject, name, 0, upperBound, arg); | ||
| double intpart; | ||
| if (std::modf(num, &intpart) != 0) return Bun::ERR::INVALID_ARG_TYPE(scope, lexicalGlobalObject, name, "integer"_s, arg); |
There was a problem hiding this comment.
is this supposed to truncate? if so std::trunc might fit better
dylan-conway
reviewed
Oct 3, 2024
| @@ -1527,6 +1478,9 @@ static inline JSC::EncodedJSValue jsBufferToString(JSC::VM& vm, JSC::JSGlobalObj | |||
| if (UNLIKELY(length == 0)) { | |||
| RELEASE_AND_RETURN(scope, JSC::JSValue::encode(JSC::jsEmptyString(vm))); | |||
| } | |||
| if (length > WTF::String::MaxLength) { | |||
There was a problem hiding this comment.
do we have a different length constant for this?
dylan-conway
reviewed
Oct 3, 2024
| RETURN_IF_EXCEPTION(scope, {}); | ||
| } | ||
|
|
||
| if (!lengthValue.isUndefined()) { | ||
| end = parseIndex(lexicalGlobalObject, scope, lengthValue); | ||
| end = parseIndex(lexicalGlobalObject, scope, "end"_s, lengthValue, limit - start); |
dylan-conway
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pulled out of #13757 to merge independently
wip: i expect having to update some test messages once this runs through the first time