New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make v8 stack trace parser code more careful #14205

Merged

Jarred-Sumner merged 2 commits into main from jarred/v8-stack-crash

Oct 1, 2024

Collaborator

Jarred-Sumner commented Sep 27, 2024

What does this PR do?

Make v8 stack trace parser code more careful

How did you verify your code works?


          Make v8 stack trace parser code more careful

c89c585

robobun commented Sep 27, 2024 •

edited

Loading

❌ @Jarred-Sumner, your commit b492364 has 11 failures in #4036:

test/js/node/test/parallel/fs-watch-recursive-add-file.test.js - 1 failing on 🍎 14 aarch64

test/js/node/test/parallel/fs-watch-recursive-add-file.test.js - 1 failing on 🍎 14 x64

test/integration/next-pages/test/next-build.test.ts - 1 failing on 🍎 14 aarch64

test/js/node/watch/fs.watch.test.ts - 3 failing on 🍎 14 aarch64

test/js/node/watch/fs.watch.test.ts - 2 failing on 🍎 14 x64

test/js/node/test/parallel/fs-watch-recursive-add-folder.test.js - 1 failing on 🍎 14 aarch64

test/js/node/test/parallel/child-process-exec-timeout-kill.test.js - 1 failing on 🍎 14 aarch64

test/js/web/fetch/fetch-tcp-stress.test.ts - timeout on 🍎 13 aarch64

test/js/web/fetch/fetch-tcp-stress.test.ts - timeout on 🍎 14 x64

test/js/web/streams/streams.test.js - 1 failing on 🍎 13 aarch64

test/js/web/streams/streams.test.js - 1 failing on 🍎 13 x64

test/js/web/streams/streams.test.js - 1 failing on 🍎 14 x64

test/js/bun/http/fetch-file-upload.test.ts - 1 failing on 🪟 x64

test/cli/install/bun-upgrade.test.ts - 1 failing on 🐧 20.04 x64

test/cli/install/bun-upgrade.test.ts - 1 failing on 🐧 12 x64

test/cli/hot/watch.test.ts - 1 failing on 🪟 x64-baseline

test/cli/hot/watch.test.ts - 1 failing on 🪟 x64

test/cli/watch/watch.test.ts - 2 failing on 🪟 x64-baseline

test/cli/watch/watch.test.ts - 2 failing on 🪟 x64


          Merge branch 'main' into jarred/v8-stack-crash

b492364

Jarred-Sumner merged commit 7720d23 into main

47 checks passed

Jarred-Sumner deleted the jarred/v8-stack-crash branch

October 1, 2024 02:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet