Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: lowercase primitive expectations of ERR_INVALID_ARG_TYPE #14284

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

nektro
Copy link
Contributor

@nektro nektro commented Oct 2, 2024

will make #14177 have to do less work, node does this conversion internally but there's no reason not to only send the correct expecteds

@robobun
Copy link

robobun commented Oct 2, 2024

@nektro, your commit 09e4cad has 15 failures in #4195:

  • test/js/node/test/parallel/fs-watch-recursive-add-file-with-url.test.js - 1 failing on 🍎 14 x64
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🍎 14 x64
  • test/js/web/streams/streams.test.js - 1 failing on 🍎 13 x64
  • test/js/web/fetch/fetch.test.ts - 1 failing on 🍎 14 aarch64
  • test/js/node/watch/fs.watch.test.ts - timeout on 🍎 14 aarch64
  • test/js/node/watch/fs.watch.test.ts - 3 failing on 🍎 14 x64
  • test/js/node/test/parallel/fs-watch-recursive-add-folder.test.js - 1 failing on 🍎 14 aarch64
  • test/js/node/test/parallel/child-process-exec-timeout-kill.test.js - 1 failing on 🍎 14 aarch64
  • test/cli/install/registry/bun-install-registry.test.ts - 1 failing on 🍎 13 x64
  • test/js/web/fetch/fetch.brotli.test.ts - 1 failing on 🐧 12 x64
  • test/js/web/fetch/fetch.brotli.test.ts - 1 failing on 🐧 22.04 x64
  • test/js/web/fetch/fetch.brotli.test.ts - 1 failing on 🐧 20.04 x64
  • test/js/web/fetch/fetch.brotli.test.ts - 1 failing on 🐧 20.04 x64-baseline
  • test/js/web/fetch/fetch.brotli.test.ts - 1 failing on 🐧 22.04 x64-baseline
  • test/js/web/fetch/fetch.brotli.test.ts - 1 failing on 🐧 12 x64-baseline
  • test/js/web/fetch/fetch.brotli.test.ts - 1 failing on 🐧 22.04 aarch64
  • test/js/web/fetch/fetch.brotli.test.ts - 1 failing on 🐧 20.04 aarch64
  • test/js/web/fetch/fetch.brotli.test.ts - 1 failing on 🐧 12 aarch64
  • test/js/web/fetch/fetch-tcp-stress.test.ts - 4 failing on 🍎 13 aarch64
  • test/js/web/fetch/fetch-tcp-stress.test.ts - timeout on 🍎 13 x64
  • test/js/web/fetch/fetch-tcp-stress.test.ts - timeout on 🍎 14 aarch64
  • test/js/web/fetch/fetch-tcp-stress.test.ts - 4 failing on 🍎 14 x64
  • test/js/bun/http/serve-body-leak.test.ts - 1 failing on 🐧 22.04 x64
  • test/cli/run/run-crash-handler.test.ts - timeout on 🪟 x64-baseline
  • test/cli/run/run-crash-handler.test.ts - timeout on 🪟 x64
  • test/cli/watch/watch.test.ts - 2 failing on 🪟 x64-baseline
  • test/cli/watch/watch.test.ts - 2 failing on 🪟 x64
  • test/js/bun/http/fetch-file-upload.test.ts - 1 failing on 🪟 x64-baseline
  • test/cli/hot/watch.test.ts - 2 failing on 🪟 x64-baseline
  • test/cli/hot/watch.test.ts - 2 failing on 🪟 x64
  • @nektro nektro marked this pull request as ready for review October 2, 2024 03:30
    @nektro nektro merged commit e44d10c into main Oct 2, 2024
    49 checks passed
    @nektro nektro deleted the nektro-patch-17113 branch October 2, 2024 03:37
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants