New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BunProcess: dont use for-loop for isSignalName #14285

Merged

nektro merged 1 commit into main from nektro-patch-19013

Oct 2, 2024

Contributor

nektro commented Oct 2, 2024

small followup to #14177


          BunProcess: dont use for-loop for isSignalName

25e6e69

robobun commented Oct 2, 2024 •

edited

Loading

❌ @nektro, your commit 25e6e69 has 14 failures in #4208:

test/js/web/streams/streams.test.js - 1 failing on 🍎 14 x64

test/js/node/test/parallel/fs-watch-recursive-add-file-with-url.test.js - 1 failing on 🍎 14 aarch64

test/js/node/test/parallel/fs-watch-recursive-add-folder.test.js - 1 failing on 🍎 13 aarch64

test/js/node/test/parallel/child-process-exec-timeout-kill.test.js - 1 failing on 🍎 13 aarch64

test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🍎 13 aarch64

test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🍎 14 aarch64

test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🍎 14 x64

test/cli/run/run-crash-handler.test.ts - timeout on 🪟 x64

test/cli/run/run-crash-handler.test.ts - timeout on 🪟 x64-baseline

test/js/web/fetch/fetch-tcp-stress.test.ts - timeout on 🍎 13 aarch64

test/js/web/fetch/fetch-tcp-stress.test.ts - timeout on 🍎 14 aarch64

test/js/web/fetch/fetch-tcp-stress.test.ts - 4 failing on 🍎 14 x64

test/js/node/watch/fs.watch.test.ts - 1 failing on 🍎 14 aarch64

test/js/node/watch/fs.watch.test.ts - 4 failing on 🍎 13 aarch64

test/js/node/watch/fs.watch.test.ts - 3 failing on 🍎 14 x64

test/js/node/net/node-net-server.test.ts - 1 failing on 🪟 x64

test/cli/watch/watch.test.ts - 2 failing on 🪟 x64

test/cli/watch/watch.test.ts - 2 failing on 🪟 x64-baseline

test/cli/install/bun-link.test.ts - 1 failing on 🪟 x64-baseline

test/cli/hot/watch.test.ts - 2 failing on 🪟 x64-baseline

test/cli/hot/watch.test.ts - 2 failing on 🪟 x64

test/js/bun/http/bun-serve-static.test.ts - 4 failing on 🍎 14 aarch64

test/js/bun/http/bun-serve-static.test.ts - timeout on 🍎 13 aarch64

test/cli/install/registry/bun-install-registry.test.ts - 1 failing on 🍎 14 aarch64

nektro marked this pull request as ready for review

October 2, 2024 06:41

nektro merged commit 531d78a into main

47 of 49 checks passed

nektro deleted the nektro-patch-19013 branch

October 2, 2024 06:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet