-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(node:http2) Implement HTTP2 server support #14286
Conversation
13d248c
to
4f6b936
Compare
f30f9e5
to
d65f356
Compare
0ae142a
to
4860442
Compare
68957f2
to
0182b18
Compare
please merge this. waiting with fingers crossed 🤞 |
I tested this PR against my demo repository to reproduce #14249 last Friday (oct 11) using the prebuilt binary with These are the two binaries I've tested: -rwxr-xr-x 1 97M oct 14 15:44 bun-b30e238d9be315441a07e3ebab8c9e6f6de55037-pr14286
-rwxr-xr-x 1 96M oct 11 07:55 bun-e16c1fcc052a188724fb3a019bada915077c4fa3-pr14286 |
ed19c49
to
ca7dd0e
Compare
Co-authored-by: Jarred Sumner <[email protected]>
1ea33f2
to
b1582f4
Compare
@cirospaciari: everything seems to be working well when I am using |
What does this PR do?
Major Client compatibility fixes + Server implementation
Fix: #8823
Fix: #14249
Fix: #8549
Fix: #9228
Notes
Push (not supported in most browsers):
HTTP1 compatibility aka ALPN negotiation (blocked on http module implementation):
WebSocket Proxing using RFC8441 (disable by default on node.js);
ALTSVC using RFC7838:
In-Progress:
Progress:
Class: ServerHttp2Session
Class: ClientHttp2Session
Class: Http2Stream
Class: ClientHttp2Stream
Class: ServerHttp2Stream
Class: Http2Server
Class: Http2SecureServer
Module:
Compatibility API
Class: http2.Http2ServerRequest
Class: http2.Http2ServerResponse
How did you verify your code works?