Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure BunString::toStringRef increases ref count #14507

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

dylan-conway
Copy link
Collaborator

What does this PR do?

Discovered after webkit upgrade

How did you verify your code works?

manually

@robobun
Copy link

robobun commented Oct 12, 2024

@dylan-conway, your commit 360925b has 13 failures in #4894:

  • test/regression/issue/ctrl-c.test.ts - illegal instruction at address 0x7ff81cd5a37b on 🍎 13 x64
  • test/cli/install/bun-install.test.ts - 1 failing on 🐧 20.04 x64
  • test/cli/install/bun-install.test.ts - 1 failing on 🐧 22.04 x64
  • test/cli/install/bun-install.test.ts - 1 failing on 🐧 20.04 x64-baseline
  • test/cli/install/bun-install.test.ts - 1 failing on 🐧 22.04 x64-baseline
  • test/js/web/fetch/fetch.tls.test.ts - 1 failing on 🍎 13 aarch64
  • test/cli/run/require-cache.test.ts - 1 failing on 🪟 x64-baseline
  • test/js/node/test/parallel/http2-server-rst-before-respond.test.js - 1 failing on 🍎 13 aarch64
  • test/js/node/test/parallel/http2-server-rst-before-respond.test.js - 1 failing on 🪟 x64-baseline
  • test/js/node/test/parallel/http2-server-rst-before-respond.test.js - 1 failing on 🍎 14 aarch64
  • test/js/node/test/parallel/http2-server-rst-before-respond.test.js - 1 failing on 🪟 x64
  • test/js/node/test/parallel/http2-server-rst-before-respond.test.js - 1 failing on 🐧 12 x64
  • test/js/node/test/parallel/http2-server-rst-before-respond.test.js - 1 failing on 🐧 22.04 x64
  • test/js/node/test/parallel/http2-server-rst-before-respond.test.js - 1 failing on 🐧 20.04 x64
  • test/js/node/test/parallel/http2-server-rst-before-respond.test.js - 1 failing on 🍎 13 x64
  • test/js/node/test/parallel/http2-server-rst-before-respond.test.js - 1 failing on 🍎 14 x64
  • test/js/node/test/parallel/http2-server-rst-before-respond.test.js - 1 failing on 🐧 22.04 x64-baseline
  • test/js/node/test/parallel/http2-server-rst-before-respond.test.js - 1 failing on 🐧 12 x64-baseline
  • test/js/node/test/parallel/http2-server-rst-before-respond.test.js - 1 failing on 🐧 20.04 x64-baseline
  • test/js/node/test/parallel/http2-large-write-close.test.js - 1 failing on 🍎 13 aarch64
  • test/js/node/test/parallel/http2-large-write-close.test.js - 1 failing on 🍎 14 aarch64
  • test/js/node/test/parallel/http2-large-write-close.test.js - 1 failing on 🐧 22.04 x64
  • test/js/node/test/parallel/http2-large-write-close.test.js - 1 failing on 🐧 20.04 x64
  • test/js/node/test/parallel/http2-large-write-close.test.js - 1 failing on 🐧 12 x64
  • test/js/node/test/parallel/http2-large-write-close.test.js - 1 failing on 🍎 13 x64
  • test/js/node/test/parallel/http2-large-write-close.test.js - 1 failing on 🍎 14 x64
  • test/js/node/test/parallel/http2-large-write-close.test.js - 1 failing on 🐧 22.04 x64-baseline
  • test/js/node/test/parallel/http2-large-write-close.test.js - 1 failing on 🐧 12 x64-baseline
  • test/js/node/test/parallel/http2-large-write-close.test.js - 1 failing on 🐧 20.04 x64-baseline
  • test/js/node/test/parallel/http2-compat-write-early-hints.test.js - timeout on 🍎 13 aarch64
  • test/js/node/test/parallel/http2-compat-write-early-hints.test.js - timeout on 🪟 x64-baseline
  • test/js/node/test/parallel/http2-compat-write-early-hints.test.js - timeout on 🍎 14 aarch64
  • test/js/node/test/parallel/http2-compat-write-early-hints.test.js - timeout on 🪟 x64
  • test/js/node/test/parallel/http2-compat-write-early-hints.test.js - timeout on 🐧 12 x64
  • test/js/node/test/parallel/http2-compat-write-early-hints.test.js - timeout on 🐧 22.04 x64
  • test/js/node/test/parallel/http2-compat-write-early-hints.test.js - timeout on 🐧 20.04 x64
  • test/js/node/test/parallel/http2-compat-write-early-hints.test.js - timeout on 🍎 13 x64
  • test/js/node/test/parallel/http2-compat-write-early-hints.test.js - timeout on 🍎 14 x64
  • test/js/node/test/parallel/http2-compat-write-early-hints.test.js - timeout on 🐧 22.04 x64-baseline
  • test/js/node/test/parallel/http2-compat-write-early-hints.test.js - timeout on 🐧 12 x64-baseline
  • test/js/node/test/parallel/http2-compat-write-early-hints.test.js - timeout on 🐧 20.04 x64-baseline
  • test/js/bun/http/fetch-file-upload.test.ts - 1 failing on 🪟 x64-baseline
  • test/js/bun/http/fetch-file-upload.test.ts - 1 failing on 🪟 x64
  • test/cli/hot/watch.test.ts - 1 failing on 🪟 x64-baseline
  • test/cli/hot/watch.test.ts - 1 failing on 🪟 x64
  • test/js/bun/http/bun-serve-static.test.ts - 2 failing on 🍎 13 aarch64
  • test/cli/install/registry/bun-install-registry.test.ts - 1 failing on 🪟 x64
  • test/cli/watch/watch.test.ts - 2 failing on 🪟 x64
  • test/cli/watch/watch.test.ts - 2 failing on 🪟 x64-baseline
  • test/js/node/test/parallel/http2-compat-write-early-hints-invalid-argument-type.test.js - 1 failing on 🍎 13 aarch64
  • test/js/node/test/parallel/http2-compat-write-early-hints-invalid-argument-type.test.js - 1 failing on 🪟 x64-baseline
  • test/js/node/test/parallel/http2-compat-write-early-hints-invalid-argument-type.test.js - 1 failing on 🪟 x64
  • test/js/node/test/parallel/http2-compat-write-early-hints-invalid-argument-type.test.js - 1 failing on 🍎 14 aarch64
  • test/js/node/test/parallel/http2-compat-write-early-hints-invalid-argument-type.test.js - 1 failing on 🐧 22.04 x64
  • test/js/node/test/parallel/http2-compat-write-early-hints-invalid-argument-type.test.js - 1 failing on 🐧 20.04 x64
  • test/js/node/test/parallel/http2-compat-write-early-hints-invalid-argument-type.test.js - 1 failing on 🐧 12 x64
  • test/js/node/test/parallel/http2-compat-write-early-hints-invalid-argument-type.test.js - 1 failing on 🍎 13 x64
  • test/js/node/test/parallel/http2-compat-write-early-hints-invalid-argument-type.test.js - 1 failing on 🍎 14 x64
  • test/js/node/test/parallel/http2-compat-write-early-hints-invalid-argument-type.test.js - 1 failing on 🐧 22.04 x64-baseline
  • test/js/node/test/parallel/http2-compat-write-early-hints-invalid-argument-type.test.js - 1 failing on 🐧 12 x64-baseline
  • test/js/node/test/parallel/http2-compat-write-early-hints-invalid-argument-type.test.js - 1 failing on 🐧 20.04 x64-baseline
  • Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants