Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

h2 visited memory #14640

Closed
wants to merge 15 commits into from
Closed

h2 visited memory #14640

wants to merge 15 commits into from
+236 −234

Conversation

cirospaciari
Copy link
Collaborator

What does this PR do?

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

@robobun
Copy link

robobun commented Oct 17, 2024 •
edited
Loading

❌ @cirospaciari, your commit a790c00 has 72 failures in #4996:

  • test/js/web/fetch/fetch-leak.test.ts - 1 failing on 🪟 x64-baseline
  • test/js/node/test/parallel/http2-zero-length-write.test.js - timeout on 🪟 x64
  • test/js/node/test/parallel/http2-zero-length-write.test.js - timeout on 🍎 13 aarch64
  • test/js/node/test/parallel/http2-zero-length-write.test.js - timeout on 🐧 12 x64-baseline
  • test/js/node/test/parallel/http2-zero-length-write.test.js - timeout on 🐧 20.04 x64-baseline
  • test/js/node/test/parallel/http2-zero-length-write.test.js - timeout on 🐧 22.04 x64-baseline
  • test/js/node/test/parallel/http2-zero-length-write.test.js - timeout on 🪟 x64-baseline
  • test/js/node/test/parallel/http2-zero-length-write.test.js - timeout on 🐧 12 x64
  • test/js/node/test/parallel/http2-zero-length-write.test.js - timeout on 🐧 20.04 x64
  • test/js/node/test/parallel/http2-zero-length-write.test.js - timeout on 🐧 22.04 x64
  • test/js/node/test/parallel/http2-zero-length-write.test.js - timeout on 🐧 12 aarch64
  • test/js/node/test/parallel/http2-zero-length-write.test.js - timeout on 🐧 20.04 aarch64
  • test/js/node/test/parallel/http2-zero-length-write.test.js - timeout on 🐧 22.04 aarch64
  • test/js/node/test/parallel/http2-zero-length-write.test.js - timeout on 🍎 13 x64
  • test/js/node/test/parallel/http2-zero-length-write.test.js - timeout on 🍎 14 aarch64
  • test/js/node/test/parallel/http2-zero-length-write.test.js - timeout on 🍎 14 x64
  • test/js/node/test/parallel/zlib.test.js - 1 failing on 🍎 13 aarch64
  • test/js/node/fs/fs.test.ts - 1 failing on 🐧 20.04 x64
  • test/cli/install/migration/complex-workspace.test.ts - timeout on 🐧 22.04 x64-baseline
  • test/bundler/bundler_compile.test.ts - 8 failing on 🪟 x64-baseline
  • test/js/third_party/grpc-js/test-server.test.ts - 2 failing on 🪟 x64
  • test/js/third_party/grpc-js/test-server.test.ts - 2 failing on 🐧 22.04 x64-baseline
  • test/js/third_party/grpc-js/test-server.test.ts - 2 failing on 🐧 20.04 x64-baseline
  • test/js/third_party/grpc-js/test-server.test.ts - 2 failing on 🐧 12 x64-baseline
  • test/js/third_party/grpc-js/test-server.test.ts - 2 failing on 🐧 20.04 x64
  • test/js/third_party/grpc-js/test-server.test.ts - 2 failing on 🐧 22.04 x64
  • test/js/third_party/grpc-js/test-server.test.ts - 2 failing on 🐧 12 x64
  • test/js/third_party/grpc-js/test-server.test.ts - 2 failing on 🪟 x64-baseline
  • test/js/third_party/grpc-js/test-server.test.ts - 2 failing on 🍎 13 aarch64
  • test/js/third_party/grpc-js/test-server.test.ts - 2 failing on 🐧 20.04 aarch64
  • test/js/third_party/grpc-js/test-server.test.ts - 2 failing on 🐧 22.04 aarch64
  • test/js/third_party/grpc-js/test-server.test.ts - 2 failing on 🐧 12 aarch64
  • test/js/third_party/grpc-js/test-server.test.ts - 2 failing on 🍎 13 x64
  • test/js/third_party/grpc-js/test-server.test.ts - 2 failing on 🍎 14 aarch64
  • test/js/third_party/grpc-js/test-server.test.ts - 2 failing on 🍎 14 x64
  • test/js/node/test/parallel/http2-zero-length-header.test.js - timeout on 🪟 x64
  • test/js/node/test/parallel/http2-zero-length-header.test.js - timeout on 🍎 13 aarch64
  • test/js/node/test/parallel/http2-zero-length-header.test.js - timeout on 🐧 22.04 x64-baseline
  • test/js/node/test/parallel/http2-zero-length-header.test.js - timeout on 🐧 20.04 x64-baseline
  • test/js/node/test/parallel/http2-zero-length-header.test.js - timeout on 🐧 12 x64-baseline
  • test/js/node/test/parallel/http2-zero-length-header.test.js - timeout on 🍎 13 x64
  • test/js/node/test/parallel/http2-zero-length-header.test.js - timeout on 🐧 20.04 x64
  • test/js/node/test/parallel/http2-zero-length-header.test.js - timeout on 🐧 22.04 x64
  • test/js/node/test/parallel/http2-zero-length-header.test.js - timeout on 🐧 12 x64
  • test/js/node/test/parallel/http2-zero-length-header.test.js - timeout on 🪟 x64-baseline
  • test/js/node/test/parallel/http2-zero-length-header.test.js - timeout on 🐧 20.04 aarch64
  • test/js/node/test/parallel/http2-zero-length-header.test.js - timeout on 🐧 22.04 aarch64
  • test/js/node/test/parallel/http2-zero-length-header.test.js - timeout on 🐧 12 aarch64
  • test/js/node/test/parallel/http2-zero-length-header.test.js - timeout on 🍎 14 aarch64
  • test/js/node/test/parallel/http2-zero-length-header.test.js - timeout on 🍎 14 x64
  • test/js/third_party/grpc-js/test-channel-credentials.test.ts - 1 failing on 🪟 x64
  • test/js/third_party/grpc-js/test-channel-credentials.test.ts - 1 failing on 🍎 13 aarch64
  • test/js/third_party/grpc-js/test-channel-credentials.test.ts - 1 failing on 🐧 20.04 x64-baseline
  • test/js/third_party/grpc-js/test-channel-credentials.test.ts - 1 failing on 🐧 12 x64-baseline
  • test/js/third_party/grpc-js/test-channel-credentials.test.ts - 1 failing on 🐧 22.04 x64-baseline
  • test/js/third_party/grpc-js/test-channel-credentials.test.ts - 1 failing on 🪟 x64-baseline
  • test/js/third_party/grpc-js/test-channel-credentials.test.ts - 1 failing on 🍎 13 x64
  • test/js/third_party/grpc-js/test-channel-credentials.test.ts - 1 failing on 🐧 12 x64
  • test/js/third_party/grpc-js/test-channel-credentials.test.ts - 1 failing on 🐧 22.04 x64
  • test/js/third_party/grpc-js/test-channel-credentials.test.ts - 1 failing on 🐧 20.04 x64
  • test/js/third_party/grpc-js/test-channel-credentials.test.ts - 1 failing on 🍎 14 aarch64
  • test/js/third_party/grpc-js/test-channel-credentials.test.ts - 1 failing on 🐧 12 aarch64
  • test/js/third_party/grpc-js/test-channel-credentials.test.ts - 1 failing on 🐧 22.04 aarch64
  • test/js/third_party/grpc-js/test-channel-credentials.test.ts - 1 failing on 🐧 20.04 aarch64
  • test/js/third_party/grpc-js/test-channel-credentials.test.ts - 1 failing on 🍎 14 x64
  • test/js/node/test/parallel/http2-write-callbacks.test.js - 1 failing on 🪟 x64
  • test/js/node/test/parallel/http2-write-callbacks.test.js - 1 failing on 🍎 13 aarch64
  • test/js/node/test/parallel/http2-write-callbacks.test.js - 1 failing on 🐧 20.04 x64-baseline
  • test/js/node/test/parallel/http2-write-callbacks.test.js - 1 failing on 🐧 12 x64-baseline
  • test/js/node/test/parallel/http2-write-callbacks.test.js - 1 failing on 🐧 22.04 x64-baseline
  • test/js/node/test/parallel/http2-write-callbacks.test.js - 1 failing on 🪟 x64-baseline
  • test/js/node/test/parallel/http2-write-callbacks.test.js - 1 failing on 🐧 12 x64
  • test/js/node/test/parallel/http2-write-callbacks.test.js - 1 failing on 🐧 22.04 x64
  • test/js/node/test/parallel/http2-write-callbacks.test.js - 1 failing on 🐧 20.04 x64
  • test/js/node/test/parallel/http2-write-callbacks.test.js - 1 failing on 🐧 12 aarch64
  • test/js/node/test/parallel/http2-write-callbacks.test.js - 1 failing on 🐧 22.04 aarch64
  • test/js/node/test/parallel/http2-write-callbacks.test.js - 1 failing on 🐧 20.04 aarch64
  • test/js/node/test/parallel/http2-write-callbacks.test.js - 1 failing on 🍎 13 x64
  • test/js/node/test/parallel/http2-write-callbacks.test.js - 1 failing on 🍎 14 aarch64
  • test/js/node/test/parallel/http2-write-callbacks.test.js - 1 failing on 🍎 14 x64
  • test/js/node/test/parallel/http2-large-write-destroy.test.js - 1 failing on 🪟 x64
  • test/js/node/test/parallel/http2-large-write-destroy.test.js - 1 failing on 🍎 13 aarch64
  • test/js/node/test/parallel/http2-large-write-destroy.test.js - 1 failing on 🐧 20.04 x64-baseline
  • test/js/node/test/parallel/http2-large-write-destroy.test.js - 1 failing on 🐧 12 x64-baseline
  • test/js/node/test/parallel/http2-large-write-destroy.test.js - 1 failing on 🐧 22.04 x64-baseline
  • test/js/node/test/parallel/http2-large-write-destroy.test.js - 1 failing on 🪟 x64-baseline
  • test/js/node/test/parallel/http2-large-write-destroy.test.js - 1 failing on 🐧 12 x64
  • test/js/node/test/parallel/http2-large-write-destroy.test.js - 1 failing on 🐧 22.04 x64
  • test/js/node/test/parallel/http2-large-write-destroy.test.js - 1 failing on 🐧 20.04 x64
  • test/js/node/test/parallel/http2-large-write-destroy.test.js - 1 failing on 🐧 12 aarch64
  • test/js/node/test/parallel/http2-large-write-destroy.test.js - 1 failing on 🐧 22.04 aarch64
  • test/js/node/test/parallel/http2-large-write-destroy.test.js - 1 failing on 🐧 20.04 aarch64
  • test/js/node/test/parallel/http2-large-write-destroy.test.js - 1 failing on 🍎 13 x64
  • test/js/node/test/parallel/http2-large-write-destroy.test.js - 1 failing on 🍎 14 aarch64
  • test/js/node/test/parallel/http2-large-write-destroy.test.js - 1 failing on 🍎 14 x64
  • test/js/node/test/parallel/http2-compat-expect-handling.test.js - timeout on 🪟 x64
  • test/js/node/test/parallel/http2-compat-expect-handling.test.js - timeout on 🍎 13 aarch64
  • test/js/node/test/parallel/http2-compat-expect-handling.test.js - timeout on 🐧 12 x64-baseline
  • test/js/node/test/parallel/http2-compat-expect-handling.test.js - timeout on 🐧 20.04 x64-baseline
  • test/js/node/test/parallel/http2-compat-expect-handling.test.js - timeout on 🐧 22.04 x64-baseline
  • test/js/node/test/parallel/http2-compat-expect-handling.test.js - timeout on 🪟 x64-baseline
  • test/js/node/test/parallel/http2-compat-expect-handling.test.js - timeout on 🐧 12 x64
  • test/js/node/test/parallel/http2-compat-expect-handling.test.js - timeout on 🐧 20.04 x64
  • test/js/node/test/parallel/http2-compat-expect-handling.test.js - timeout on 🐧 22.04 x64
  • test/js/node/test/parallel/http2-compat-expect-handling.test.js - timeout on 🐧 12 aarch64
  • test/js/node/test/parallel/http2-compat-expect-handling.test.js - timeout on 🐧 20.04 aarch64
  • test/js/node/test/parallel/http2-compat-expect-handling.test.js - timeout on 🐧 22.04 aarch64
  • test/js/node/test/parallel/http2-compat-expect-handling.test.js - timeout on 🍎 13 x64
  • test/js/node/test/parallel/http2-compat-expect-handling.test.js - timeout on 🍎 14 aarch64
  • test/js/node/test/parallel/http2-compat-expect-handling.test.js - timeout on 🍎 14 x64
  • test/js/node/test/parallel/http2-socket-proxy.test.js - timeout on 🍎 13 aarch64
  • test/js/node/test/parallel/http2-socket-proxy.test.js - timeout on 🪟 x64
  • test/js/node/test/parallel/http2-socket-proxy.test.js - timeout on 🍎 13 x64
  • test/js/node/test/parallel/http2-socket-proxy.test.js - timeout on 🐧 12 x64-baseline
  • test/js/node/test/parallel/http2-socket-proxy.test.js - timeout on 🐧 20.04 x64-baseline
  • test/js/node/test/parallel/http2-socket-proxy.test.js - timeout on 🐧 22.04 x64-baseline
  • test/js/node/test/parallel/http2-socket-proxy.test.js - timeout on 🪟 x64-baseline
  • test/js/node/test/parallel/http2-socket-proxy.test.js - timeout on 🐧 12 x64
  • test/js/node/test/parallel/http2-socket-proxy.test.js - timeout on 🐧 20.04 x64
  • test/js/node/test/parallel/http2-socket-proxy.test.js - timeout on 🐧 22.04 x64
  • test/js/node/test/parallel/http2-socket-proxy.test.js - timeout on 🍎 14 aarch64
  • test/js/node/test/parallel/http2-socket-proxy.test.js - timeout on 🐧 12 aarch64
  • test/js/node/test/parallel/http2-socket-proxy.test.js - timeout on 🐧 20.04 aarch64
  • test/js/node/test/parallel/http2-socket-proxy.test.js - timeout on 🐧 22.04 aarch64
  • test/js/node/test/parallel/http2-socket-proxy.test.js - timeout on 🍎 14 x64
  • test/js/node/test/parallel/http2-status-code.test.js - 1 failing on 🪟 x64
  • test/js/node/test/parallel/http2-status-code.test.js - 1 failing on 🐧 12 x64-baseline
  • test/js/node/test/parallel/http2-status-code.test.js - 1 failing on 🐧 20.04 x64-baseline
  • test/js/node/test/parallel/http2-status-code.test.js - 1 failing on 🐧 22.04 x64-baseline
  • test/js/node/test/parallel/http2-status-code.test.js - 1 failing on 🪟 x64-baseline
  • test/js/node/test/parallel/http2-status-code.test.js - 1 failing on 🐧 20.04 x64
  • test/js/node/test/parallel/http2-status-code.test.js - 1 failing on 🐧 22.04 x64
  • test/js/node/test/parallel/http2-status-code.test.js - 1 failing on 🐧 12 x64
  • test/js/node/test/parallel/http2-status-code.test.js - 1 failing on 🍎 13 aarch64
  • test/js/node/test/parallel/http2-status-code.test.js - 1 failing on 🐧 20.04 aarch64
  • test/js/node/test/parallel/http2-status-code.test.js - 1 failing on 🐧 22.04 aarch64
  • test/js/node/test/parallel/http2-status-code.test.js - 1 failing on 🐧 12 aarch64
  • test/js/node/test/parallel/http2-status-code.test.js - 1 failing on 🍎 13 x64
  • test/js/node/test/parallel/http2-status-code.test.js - 1 failing on 🍎 14 aarch64
  • test/js/node/test/parallel/http2-status-code.test.js - 1 failing on 🍎 14 x64
  • test/js/node/test/parallel/http2-createwritereq.test.js - 1 failing on 🪟 x64
  • test/js/node/test/parallel/http2-createwritereq.test.js - 1 failing on 🐧 12 x64-baseline
  • test/js/node/test/parallel/http2-createwritereq.test.js - 1 failing on 🐧 20.04 x64-baseline
  • test/js/node/test/parallel/http2-createwritereq.test.js - 1 failing on 🐧 22.04 x64-baseline
  • test/js/node/test/parallel/http2-createwritereq.test.js - 1 failing on 🪟 x64-baseline
  • test/js/node/test/parallel/http2-createwritereq.test.js - 1 failing on 🐧 20.04 x64
  • test/js/node/test/parallel/http2-createwritereq.test.js - 1 failing on 🐧 22.04 x64
  • test/js/node/test/parallel/http2-createwritereq.test.js - 1 failing on 🐧 12 x64
  • test/js/node/test/parallel/http2-createwritereq.test.js - 1 failing on 🍎 13 aarch64
  • test/js/node/test/parallel/http2-createwritereq.test.js - 1 failing on 🐧 20.04 aarch64
  • test/js/node/test/parallel/http2-createwritereq.test.js - 1 failing on 🐧 22.04 aarch64
  • test/js/node/test/parallel/http2-createwritereq.test.js - 1 failing on 🐧 12 aarch64
  • test/js/node/test/parallel/http2-createwritereq.test.js - 1 failing on 🍎 13 x64
  • test/js/node/test/parallel/http2-createwritereq.test.js - 1 failing on 🍎 14 aarch64
  • test/js/node/test/parallel/http2-createwritereq.test.js - 1 failing on 🍎 14 x64
  • test/js/node/test/parallel/http2-res-corked.test.js - 1 failing on 🍎 13 aarch64
  • test/js/node/test/parallel/http2-res-corked.test.js - 1 failing on 🪟 x64
  • test/js/node/test/parallel/http2-res-corked.test.js - 1 failing on 🍎 13 x64
  • test/js/node/test/parallel/http2-res-corked.test.js - 1 failing on 🐧 12 x64-baseline
  • test/js/node/test/parallel/http2-res-corked.test.js - 1 failing on 🐧 20.04 x64-baseline
  • test/js/node/test/parallel/http2-res-corked.test.js - 1 failing on 🐧 22.04 x64-baseline
  • test/js/node/test/parallel/http2-res-corked.test.js - 1 failing on 🪟 x64-baseline
  • test/js/node/test/parallel/http2-res-corked.test.js - 1 failing on 🐧 12 x64
  • test/js/node/test/parallel/http2-res-corked.test.js - 1 failing on 🐧 20.04 x64
  • test/js/node/test/parallel/http2-res-corked.test.js - 1 failing on 🐧 22.04 x64
  • test/js/node/test/parallel/http2-res-corked.test.js - 1 failing on 🍎 14 aarch64
  • test/js/node/test/parallel/http2-res-corked.test.js - 1 failing on 🐧 12 aarch64
  • test/js/node/test/parallel/http2-res-corked.test.js - 1 failing on 🐧 20.04 aarch64
  • test/js/node/test/parallel/http2-res-corked.test.js - 1 failing on 🐧 22.04 aarch64
  • test/js/node/test/parallel/http2-res-corked.test.js - 1 failing on 🍎 14 x64
    		•

    @cirospaciari cirospaciari deleted the ciro/h2-estimatedSize branch October 18, 2024 03:08
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers
    No reviews
    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    2 participants
    @cirospaciari @robobun