Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): --filter flag #8185
feat(cli): --filter flag #8185
Changes from 17 commits
ad920cb
6be006e
a734de8
c83507b
1868ad3
496bac0
1b659b3
2f33677
ea8ea8d
d8d0ffb
0c9c555
f74aad9
4adbf68
44ea630
9d17118
e68e7b0
5cb2d58
af5728c
ad18255
5b19f98
a4d1b17
024d86e
9819a13
c8c21bf
2557763
5e467cc
7f01fae
1a3fbc1
9a7ba61
63124c3
9af23ad
8ab8941
26a720d
3426873
a363f48
5637a7d
2c48289
03037de
5b91ca3
63d5cd6
127a599
c39e61d
f1db7ad
7d122b3
ca4c96d
4faf32d
7e7e55d
101a893
b4300bb
08af77a
a3f6998
a26eca6
494fa3d
a9b9ce0
d8f76f7
8e17407
75864c7
000d513
78814e6
b8abffd
3f40cc6
22dfc45
ac3ad16
da3485f
6ba7eb3
defd08f
7d6e443
f781e51
4ddddb9
a5fcbfa
4046074
e0726a3
473a2d4
ccfebfb
f7e54d8
c178624
22846af
c9ff770
5083cf6
beb3d24
32bfdb1
66b8a2d
9c0f1d6
63c4f73
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are parsing the package.json files multiple times here since it may happen again later
I'm hesitant to block the PR on this but we should figure out a way to cache this to avoid the overhead
Also, we can simplify this code a bit:
bun.sys.File.toSource(json_path, allocator);