Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option to turn on or off fullscreen button in SCORM content #83

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zameel7
Copy link
Contributor

@zameel7 zameel7 commented Aug 23, 2024

Some components by default has its own button for full screen functionality. So, the full screen button could be optional where instructors would be able to turn that on or off.

@ziafazal ziafazal self-requested a review August 30, 2024 12:42
Copy link
Collaborator

@ziafazal ziafazal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zameel7 Thanks for your contribution. Could you please take care of one suggestion?

openedxscorm/scormxblock.py Outdated Show resolved Hide resolved
@zameel7
Copy link
Contributor Author

zameel7 commented Sep 18, 2024

@zameel7 Thanks for your contribution. Could you please take care of one suggestion?

Updated the setting to use True by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants