-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade to quince #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is due to renaming quickstart to launch in tutor.
This is to address overhangio/tutor-mfe#122 As a consequence of this change, images will be tagged with a "-nightly" suffix. Next, we'll probably have to build them periodically in CI.
The package version number may not include the "-nightly" suffix. Otherwise, installation fails with: setuptools.extern.packaging.version.InvalidVersion: Invalid version: '15.0.7-nightly'
Build was failing with the following error during the installation of mysqlclient==2.2.0: #39 22.19 Collecting mysqlclient==2.2.0 (from -r requirements/production.txt (line 435)) #39 22.20 Downloading mysqlclient-2.2.0.tar.gz (89 kB) #39 22.20 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 89.5/89.5 kB 95.8 MB/s eta 0:00:00 #39 22.24 Installing build dependencies: started #39 24.79 Installing build dependencies: finished with status 'done' #39 24.81 Getting requirements to build wheel: started #39 25.07 Getting requirements to build wheel: finished with status 'error' #39 25.08 error: subprocess-exited-with-error #39 25.08 #39 25.08 × Getting requirements to build wheel did not run successfully. #39 25.08 │ exit code: 1 #39 25.08 ╰─> [24 lines of output] #39 25.08 /bin/sh: 1: pkg-config: not found #39 25.08 /bin/sh: 1: pkg-config: not found #39 25.08 Trying pkg-config --exists mysqlclient #39 25.08 Command 'pkg-config --exists mysqlclient' returned non-zero exit status 127. #39 25.08 Trying pkg-config --exists mariadb #39 25.08 Command 'pkg-config --exists mariadb' returned non-zero exit status 127. #39 25.08 Traceback (most recent call last): #39 25.08 File "/openedx/venv/lib/python3.8/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module> #39 25.08 main() #39 25.08 File "/openedx/venv/lib/python3.8/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main #39 25.08 json_out['return_val'] = hook(**hook_input['kwargs']) #39 25.08 File "/openedx/venv/lib/python3.8/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 118, in get_requires_for_build_wheel #39 25.08 return hook(config_settings) #39 25.08 File "/tmp/pip-build-env-5hyrozx4/overlay/lib/python3.8/site-packages/setuptools/build_meta.py", line 355, in get_requires_for_build_wheel #39 25.08 return self._get_build_requires(config_settings, requirements=['wheel']) #39 25.08 File "/tmp/pip-build-env-5hyrozx4/overlay/lib/python3.8/site-packages/setuptools/build_meta.py", line 325, in _get_build_requires #39 25.08 self.run_setup() #39 25.08 File "/tmp/pip-build-env-5hyrozx4/overlay/lib/python3.8/site-packages/setuptools/build_meta.py", line 341, in run_setup #39 25.08 exec(code, locals()) #39 25.08 File "<string>", line 154, in <module> #39 25.08 File "<string>", line 48, in get_config_posix #39 25.08 File "<string>", line 27, in find_package_name #39 25.08 Exception: Can not find valid pkg-config name. #39 25.08 Specify MYSQLCLIENT_CFLAGS and MYSQLCLIENT_LDFLAGS env vars manually #39 25.08 [end of output]
This contribution is part of the [FC-0012 project](https://openedx.atlassian.net/l/cp/XGS0iCcQ) which is sparked by the [Translation Infrastructure update OEP-58](https://open-edx-proposals.readthedocs.io/en/latest/architectural-decisions/oep-0058-arch-translations-management.html#specification).
I'm trying to test it but getting the following error on launch. 2023-11-20 21:24:35,513 INFO 100 [course_discovery.apps.course_metadata.management.commands.refresh_course_metadata] /openedx/discovery/course_discovery/apps/course_metadata/management/commands/refresh_course_metadata.py:134 - Command is not using threads to write data.
2023-11-20 21:24:35,515 INFO 100 [course_discovery.apps.course_metadata.management.commands.refresh_course_metadata] /openedx/discovery/course_discovery/apps/course_metadata/management/commands/refresh_course_metadata.py:178 - Executing Loader CoursesApiDataLoader, url: http://local.overhang.io/api/courses/v1/
2023-11-20 21:24:36,325 INFO 100 [course_discovery.apps.course_metadata.management.commands.refresh_course_metadata] /openedx/venv/lib/python3.8/site-packages/backoff/_common.py:105 - Backing off run_loader(...) for 0.3s (course_discovery.apps.course_metadata.models.Source.DoesNotExist: Source matching query does not exist.)
2023-11-20 21:24:36,661 INFO 100 [course_discovery.apps.course_metadata.management.commands.refresh_course_metadata] /openedx/venv/lib/python3.8/site-packages/backoff/_common.py:105 - Backing off run_loader(...) for 56.8s (course_discovery.apps.course_metadata.models.Source.DoesNotExist: Source matching query does not exist.)
2023-11-20 21:25:33,459 ERROR 100 [course_discovery.apps.course_metadata.management.commands.refresh_course_metadata] /openedx/venv/lib/python3.8/site-packages/backoff/_common.py:120 - Giving up run_loader(...) after 3 tries (course_discovery.apps.course_metadata.models.Source.DoesNotExist: Source matching query does not exist.)
2023-11-20 21:25:33,459 ERROR 100 [course_discovery.apps.course_metadata.management.commands.refresh_course_metadata] /openedx/discovery/course_discovery/apps/course_metadata/management/commands/refresh_course_metadata.py:40 - CoursesApiDataLoader failed!
Traceback (most recent call last):
File "/openedx/discovery/course_discovery/apps/course_metadata/management/commands/refresh_course_metadata.py", line 37, in execute_loader
run_loader()
File "/openedx/venv/lib/python3.8/site-packages/backoff/_sync.py", line 105, in retry
ret = target(*args, **kwargs)
File "/openedx/discovery/course_discovery/apps/course_metadata/management/commands/refresh_course_metadata.py", line 34, in run_loader
return loader_class(*loader_args).ingest()
File "/openedx/discovery/course_discovery/apps/course_metadata/data_loaders/api.py", line 51, in __init__
self.default_product_source = Source.objects.get(slug=settings.DEFAULT_PRODUCT_SOURCE_SLUG)
File "/openedx/venv/lib/python3.8/site-packages/django/db/models/manager.py", line 85, in manager_method
return getattr(self.get_queryset(), name)(*args, **kwargs)
File "/openedx/venv/lib/python3.8/site-packages/django/db/models/query.py", line 435, in get
raise self.model.DoesNotExist(
course_discovery.apps.course_metadata.models.Source.DoesNotExist: Source matching query does not exist.
CommandError: One or more of the data loaders above failed. |
Yes, this issue is the reason why we temporarily disabled the discovery and ecommerce plugins on the quince demo server. |
regisb
reviewed
Nov 21, 2023
@@ -34,7 +35,7 @@ RUN {% if is_buildkit_enabled() %}--mount=type=cache,target=/openedx/.cache/pip, | |||
# https://pypi.org/project/setuptools/ | |||
# https://pypi.org/project/pip/ | |||
# https://pypi.org/project/wheel/ | |||
setuptools==67.7.2 pip==23.1.2. wheel==0.40.0 | |||
setuptools==68.2.2 pip==23.2.1. wheel==0.41.2 | |||
|
|||
# Install a recent version of nodejs | |||
RUN pip install nodeenv==1.7.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take this opportunity to upgrade to nodeenv 1.8.0.
course-discovery now maintains its own base.in requirement for atlas the tutor-discovery no longer needs to install it.
This is related to overhangio/tutor#945
regisb
force-pushed
the
quince
branch
3 times, most recently
from
December 10, 2023 22:08
08dddae
to
1c64c45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed related to quince upgrade.