fix: fix base url for the media file links #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regisb
requested changes
Dec 8, 2023
| "overrides": { | ||
| "DISCOVERY_BASE_URL": PROTOCOL + "://{{DISCOVERY_HOST}}", | ||
| "MEDIA_URL": PROTOCOL + "://{{DISCOVERY_HOST}}/media/", | ||
| } |
There was a problem hiding this comment.
Let's not introduce new Tutor settings here. Instead, the templates should be like:
DISCOVERY_BASE_URL = "{% if ENABLE_HTTPS %}https{% else %}http{% endif %}://{{ DISCOVERY_HOST }}:8381"
MEDIA_URL = DISCOVERY_BASE_URL + "/media"
There was a problem hiding this comment.
If you are talking about PROTOCOL, It was a variable. I have removed it and used ENABLE_HTTPS now.
close overhangio#46 as this PR will fix base url for discovery and media file links
Faraz32123
force-pushed
the
fix/faraz-fix_base_url_for_media_links
branch
from
73ca49f to
74f4534
Compare
|
Replaced by #57 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating this PR for this Issue fix.