Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: tutor[dev] used to install dev dependencies #165

Merged
merged 2 commits into from
Nov 20, 2023
Merged

ci: tutor[dev] used to install dev dependencies #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38e119f
ci: tutor[dev] used to install dev dependencies
CodeWithEmad Nov 18, 2023
06e720a
chore: clean up with black
CodeWithEmad Nov 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,6 @@ jobs:
run: python -m pip install --upgrade pip setuptools
- name: Install dependencies
run: |
pip install black==23.7.0 \
isort==5.12.0 \
mypy==1.5.1 \
pylint==2.17.5 \
pytest==7.4.2 \
tutor==16.1.2 \
types-docutils==0.20.0.3 \
types-pyyaml==6.0.12.11 \
types-setuptools==68.1.0.0
pip install 'tutor[dev]>=16.1.2,<17.0.0'
- name: Test lint, types, and format
run: make test
4 changes: 3 additions & 1 deletion tutormfe/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,9 @@ def _build_3rd_party_dev_mfes_on_launch(
image_names: list[str], context_name: t.Literal["local", "dev"]
) -> list[str]:
for mfe_name, _mfe_attrs in iter_mfes():
if __version_suffix__ or (context_name == "dev" and mfe_name not in CORE_MFE_APPS):
if __version_suffix__ or (
context_name == "dev" and mfe_name not in CORE_MFE_APPS
):
# We build MFE images:
# - in nightly
# - in development for non-core apps
Expand Down
Loading