feat!: add ATLAS_OPTIONS and remove i18n-merge.js | FC-0012 #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarIthawi
changed the title
OmarIthawi
force-pushed
the
atlas-options
branch
from
b855c3e
to
1db321e
Compare
regisb
reviewed
Jan 8, 2024
I hear that as a "yes" :) Will do. Thanks @regisb. |
|
Oh wait, this PR should be on top of the nightly branch, since we don't aim to support Quince. |
|
That's right @regisb. I meant to open it on |
OmarIthawi
force-pushed
the
atlas-options
branch
2 times, most recently
from
4ddd935
to
d5c186d
Compare
|
@arbrandes @regisb this is now ready. |
regisb
reviewed
Jan 12, 2024
regisb
approved these changes
Jan 12, 2024
arbrandes
approved these changes
Jan 12, 2024
OmarIthawi
force-pushed
the
atlas-options
branch
from
d5c186d
to
cbe140a
Compare
|
@arbrandes All notes have been address, this pull request is now ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is part of the FC-0012 project which implements the Translation Infrastructure update OEP-58.