fix: add account mfe patch to show account page #221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1 @@ | |||
| - [BugFix] Add upstream footer-slot patch in account-mfe (by @hinakhadim) | |||
There was a problem hiding this comment.
the changelog needs some details, the current description is not enough to explain the underlying issue
|
Closing this PR due to merge conflicts caused by the included patch, which is preventing the patch from being applied successfully and resulting in errors. Applying: fix: import `FooterSlot` from `frontend-slot-footer` package (#1048)
error: patch failed: package-lock.json:10
error: package-lock.json: patch does not apply
error: patch failed: package.json:28
error: package.json: patch does not apply
error: patch failed: src/index.jsx:11
error: src/index.jsx: patch does not apply
Patch failed at 0001 fix: import `FooterSlot` from `frontend-slot-footer` package (#1048) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
With Tutor v18 and Tutor Indigo v18.1.0, users are unable to view the accounts page. Tutor Indigo v18.1.0 has installation of custom indigo header and footer in learning, dashboard, profile, discussion and account MFE. All MFEs are compatible with indigo header and footer except accounts MFE. The reason is:
In redwood:
Most of the MFEs using ----> footer v14
footer is installed via @openedx/frontend-slot-footer package
footer is imported like import FooterSlot from '@openedx/frontend-slot-footer';
Account MFE -----> footer v13
footer is installed via @edx/frontend-component-footer
footer is imported like import { FooterSlot } from '@edx/frontend-component-footer';
Our indigo footer is created from footer v14 and we are installing it in all MFEs (account MFE has footer v13). More details can be found on openedx/frontend-app-account#1071
This PR adds the patch in account-mfe which fixes the above issue
Solves overhangio/tutor#1111