Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add patches show ... command #1112

Merged
merged 1 commit into from
Sep 19, 2024
Merged

feat: add patches show ... command #1112

merged 1 commit into from
Sep 19, 2024

Conversation

regisb
Copy link
Contributor

@regisb regisb commented Aug 16, 2024

I found myself in a situation where I wasn't sure if a patch was correctly added by the Indigo plugin. To troubleshoot that issue, I wanted to print that rendered patch. I thought it would make a nice addition to the CLI.

Copy link
Collaborator

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. It could benefit from a unit test, but I won't insist :)

I found myself in a situation where I wasn't sure if a patch was
correctly added by the Indigo plugin. To troubleshoot that issue, I
wanted to print that rendered patch. I thought it would make a nice
addition to the CLI.
@regisb
Copy link
Contributor Author

regisb commented Sep 19, 2024

I didn't manage to write a test with an actual patch, so I added a test for an empty patch... (mocks are hard)

@regisb regisb merged commit 2959e6e into master Sep 19, 2024
2 checks passed
@regisb regisb deleted the regisb/patches-show branch September 19, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants