build: copy in copy-node-modules.sh for npm post-install hook #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This post-install hook replaces `openedx-assets npm`. Part of: openedx/edx-platform#31604
kdmccormick
force-pushed
the
kdmccormick/copy-node-modules
branch
from
bdce02a
to
64ac783
Compare
regisb
approved these changes
Jul 21, 2023
There was a problem hiding this comment.
LGTM! Don't hesitate to ping me for urgent matters, as you did on Slack. I expect to be off for the next two weeks or so.
(note to self: this change should fix the breaking nightly CI pipeline https://git.overhang.io/core/tutor/-/jobs/17881)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scripts/copy-node-modules.sh replaces
openedx-assets npm.We run it automatically as a post-install NPM hook.
That means that the script must be available when running
npm clean-install.This should merge right after openedx/edx-platform#32767 merges.
Part of: openedx/edx-platform#31604