Instrument: Remove unnecessary function param [refactor]

overlookmotel · Dec 3, 2023 · 8400838 · 8400838
1 parent 3c45b5b
commit 8400838
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/lib/instrument/blocks.js b/lib/instrument/blocks.js
@@ -234,11 +234,10 @@ function activateBlock(block, state) {
  * Activate binding.
  * Called when a binding is accessed from within a function.
  * @param {Object} binding - Binding object
- * @param {string} varName - Var name
  * @returns {undefined}
  */
-function activateBinding(binding, varName) {
-	if (!binding.varNode) binding.varNode = t.identifier(varName);
+function activateBinding(binding) {
+	if (!binding.varNode) binding.varNode = t.identifier(binding.name);
 }
 
 /**

diff --git a/lib/instrument/visitors/eval.js b/lib/instrument/visitors/eval.js
@@ -185,7 +185,7 @@ function instrumentEvalCall(callNode, block, fn, isStrict, canUseSuper, superIsP
 			// Ignore `new.target` and `super` as they're not possible to recreate.
 			// https://github.com/overlookmotel/livepack/issues/448
 			if (isExternalToFunction && varName !== 'new.target' && varName !== 'super') {
-				activateBinding(binding, varName);
+				activateBinding(binding);
 				const externalVar = getOrCreateExternalVar(fn, block, varName, binding);
 				externalVar.isReadFrom = true;
 				if (!isConst) externalVar.isAssignedTo = true;

diff --git a/lib/instrument/visitors/identifier.js b/lib/instrument/visitors/identifier.js
@@ -215,7 +215,7 @@ function resolveIdentifier(node, block, varName, fn, trail, isReadFrom, isAssign
  */
 function recordExternalVar(binding, block, varName, fn, trail, isReadFrom, isAssignedTo, state) {
 	activateBlock(block, state);
-	activateBinding(binding, varName);
+	activateBinding(binding);
 	const externalVar = getOrCreateExternalVar(fn, block, varName, binding);
 	if (isReadFrom) externalVar.isReadFrom = true;
 	if (isAssignedTo) externalVar.isAssignedTo = true;