Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Donor/Specimen/Sample - from JSON schemas #865

Open
3 tasks
joneubank opened this issue Oct 2, 2024 · 0 comments
Open
3 tasks

Remove Donor/Specimen/Sample - from JSON schemas #865

joneubank opened this issue Oct 2, 2024 · 0 comments
Assignees
@Azher2Ali
Labels
breaking-change Changes to the code might result in breaking-changes refactor-analysis-data-model

Comments

@joneubank
Copy link
Contributor

joneubank commented Oct 2, 2024 •
edited
Loading

This ticket is contributing to the epic: #863

Summary of request

Update the JSON Schemas to remove Donor, Specimen, and Samples from the base analysis schema, and allow these fields to be added to all dynamic schemas.

Details

  1. From baseSchema.json
    • Remove samples property
    • Remove definitions for sample, specimen, donor
  2. From analysisTypeRegistration.json
    • Remove samples property from list of disallowed properties

Note

We want to reuse these definitions to add to the legacy schemas.
@joneubank joneubank mentioned this issue Oct 2, 2024
Open
11 tasks
@joneubank joneubank changed the title Remove Donor/Specimen/Sample - from json schemas Remove Donor/Specimen/Sample - from JSON schemas Oct 2, 2024
@Azher2Ali Azher2Ali mentioned this issue Oct 17, 2024
Merged
@joneubank joneubank added the breaking-change Changes to the code might result in breaking-changes label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Azher2Ali Azher2Ali

Labels
breaking-change Changes to the code might result in breaking-changes refactor-analysis-data-model
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joneubank @Azher2Ali