Remove Donor, Specimen, and Samples from Base Schema and Allow in Dynamic Schemas #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joneubank
approved these changes
Oct 25, 2024
Azher2Ali
deleted the
refactor/remove-donor-specimen-sample-from-base-schema
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR updates the JSON schemas to remove Donor, Specimen, and Samples from the base analysis schema, allowing these fields to be added dynamically in analysis-type specific schemas.
Details:
baseSchema.json:
Removed the
samplesproperty.Removed definitions for
sample,specimen, anddonor.analysisTypeRegistration.json:
samplesproperty from the list of disallowed properties, allowing dynamic schemas to include these fields as needed.These changes simplify the base schema and enable more flexible handling of analysis types that may or may not require donor/specimen/sample information #865