Remove FileTypes Enum and Update References
#867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the changes outlined in issue #852.
The
FileTypesenum, located insong-core/src/main/java/bio/overture/song/core/model/enums/FileTypes.java, has been removed from the codebase as it is no longer necessary due to the recent implementation updates.Key changes include:
Removal of the
FileTypesenum from the project.Updates to the
FileEntityclass in the SCORe server to no longer reference theFileTypesenum, and removal of overloaded methods that acceptedFileTypesas arguments.Modifications to several test cases where
FileTypeswas used, replacing those references with plain string values to represent file types.These changes simplify the codebase, removing redundant functionality while ensuring that all test cases continue to pass.