Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/passport visa #706

Merged
merged 11 commits into from
May 23, 2023
Merged

Conversation

Azher2Ali
Copy link
Contributor

@Azher2Ali Azher2Ali commented May 16, 2023

This PR contains changes related to the below items :

  1. Create a visa service that will : Create a Visa Service #703
  • parseVisa → Visa class that is returned from content of Visa JWT (string)
  • validateVisa → need public key? or do we just trust the passport broker (i think we just trust the broker so these are already valid)
  • Caching pubic key using Spring Cache (CacheUtil) fetched from passport broker getPublicKey endpoint (maintained at application.yaml) and evicting every midnight
  • getPermissionsForVisa → return list of permissions for visa
  1. Create a Passport Service : Create a Passport Service #701
  • parsePassport → return Passport object from content of Passport JWT (string)
  • validatePassport (vs public key) → requires passportBroker config (to fetch public key)
  • Caching pubic key using Spring Cache (CacheUtil) fetched from passport broker getPublicKey endpoint (maintained at application.yaml) and evicting every midnight
  • getVisas → return list of visa JWTs
  • getPermissionsForPassport → return list of permissions from passport (compiled list of all permissions from all visas, remove duplicates)

image

@Azher2Ali Azher2Ali requested a review from leoraba May 19, 2023 09:47
The private/public key mentioned in the git repo was a dummy one, which was used during testing. As per the requested change, public/private keys are removed from the application.yaml
@Azher2Ali Azher2Ali requested a review from leoraba May 19, 2023 16:57
Copy link
Contributor

@leoraba leoraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@Azher2Ali Azher2Ali requested a review from leoraba May 23, 2023 20:22
Copy link
Contributor

@leoraba leoraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 approved!

@Azher2Ali Azher2Ali merged commit d8c655b into feature/develop-passport May 23, 2023
@Azher2Ali Azher2Ali deleted the feature/passportVisa branch May 23, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants