Changes related to error status 400 and updates to deletion of visa #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoraba
reviewed
Jun 1, 2023
leoraba
reviewed
Jun 1, 2023
…tion implementation( Commented out for fixing the JAR issue)
leoraba
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the earlier ticker #708 ,The issues related to API's returning HTTP 400 error status has now been fixed. With the recent changes, if any user does not authenticated with valid jwt the error code returns back as HTTP 401 (Unauthorized) with a error status {
"error": "Unauthorized",
"message": "Required request header 'Authorization' for method parameter type String is not present",
"timestamp": "2023-06-01T16:00:02.624+0000",
"path": "/visa"
}
Steps to reproduce:
Below is the ss, displaying the error status
The second change is regarding the updates to deletion of visa. Earlier, there was an option to delete the Visa with using VisaId as a parameter. Now, as we are no longer using the VisaId to fetch or update. Therefore, "type" and "value" can be used to delete the Visa now.