Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: advanced watcher usernames management #174

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wI2L
Copy link
Contributor

@wI2L wI2L commented Aug 20, 2020

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

This CL introduces a new plugin watcher that allows to add new
watcher usernames to a task, similar to how the tag plugin works.

A new field allowed_watcher_usernames has also been added to the
core model of a task template to allows pre-defined watchers usernames
at the template level. The pre-defined list of usernames of the template
is merged with the input list given during the creation of a task, ignoring
any duplicate values.

  • What is the current behavior? (You can also link to an open issue here)

n/a

  • What is the new behavior (if this is a feature change)?

See description.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No, new feature.

  • Other information:

n/a

@wI2L wI2L requested review from rbeuque74, loopfz and ybriffa August 20, 2020 20:50
@ovh-cds
Copy link
Collaborator

ovh-cds commented Aug 20, 2020

CDS Report test#798.0 ✘

  • Stage 1
    • Test ✘

@wI2L wI2L force-pushed the advanced-watchers branch from 98d770f to 01a2a17 Compare August 20, 2020 20:50
@wI2L
Copy link
Contributor Author

wI2L commented Aug 20, 2020

Will be adding some tests, but I would like to gather feedback about the implementation first.
EDIT: Need to fix prototype of Exec function of existing plugins as well.

@ovh-cds
Copy link
Collaborator

ovh-cds commented Aug 20, 2020

CDS Report test#799.0 ✘

  • Stage 1
    • Test ✘

This CL introduces a new plugin `watcher` that allows to add new
watcher usernames to a task, similar to how the `tag` plugin works.

A new field `allowed_watcher_usernames` has also been added to the
core model of a task template to allows pre-defined watchers usernames
at the template level. The pre-defined list of usernames of the template
is merged with the input list given during the creation of a task, ignoring
any duplicate values.

Signed-off-by: William Poussier <[email protected]>
@wI2L wI2L force-pushed the advanced-watchers branch from 01a2a17 to e859c5d Compare August 21, 2020 07:42
@wI2L wI2L added the 🚧 WIP 🚧 Work in progress label label Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧 WIP 🚧 Work in progress label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants