fix(garbage): subtasks are kept until the parent task is in a final state

[orandin]

• What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix

• What is the current behavior? (You can also link to an open issue here)

The subtasks are deleted even if the parent task is not done.

Side effect: If the parent task hasn't been executed before the deletion of the subtask, the parent task is in an inconsistent state. It can't determine the subtask state and continue the execution.

• What is the new behavior (if this is a feature change)?

The subtasks are kept until the parent task is in a final state.

• Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No

• Other information:

Config

utask-cfg

{
    "completed_task_expiration": "1m"
}

Scripts

scripts/sleep.sh

#!/bin/bash

/bin/sleep 60

Templates

Click here to show templates

name:             garbage-parent
description:      Test garbage (parent)

title_format:     Test garbage

allowed_resolver_usernames:   []
allow_all_resolver_usernames: true
auto_runnable: true
blocked:       false
hidden:        false

steps:
  createSubtask:
    description: "Create subtask"
    action:
      type: subtask
      configuration:
        template: garbage-subtask
  Waiting:
    dependencies:
      - createSubtask
    description: "Wait one minute"
    action:
      type: script
      configuration:
        file_path: sleep.sh

name:             garbage-subtask
description:      Test garbage (subtask)

title_format:     Test garbage (subtask)

allowed_resolver_usernames:   []
allow_all_resolver_usernames: true
auto_runnable: true
blocked:       false
hidden:        true

steps:
  Hello:
    description: "Display a message"
    action:
      type: echo
      configuration:
        output:
          foo: 'bar'

[rbeuque74]

If I understand correctly the modification on the SQL query, the subtask is deleted if it doesn't have the subtask tags, or if the parent task is in the DONE,CANCELLED,WONTFIX states.

In some weird case, if the parent task is getting deleted BEFORE the subtask, the subtask will never be deleted. That would be a case we need to support IMO