fix errno report in blobwriter, stop warning about repeat subscribe #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baallan
force-pushed
the
v4.4.4_blob_errno
branch
from
a7dcd9c to
e27da2b
Compare
|
@tom95858 sorry for the late patch; things turned up in logs yesterday. |
tom95858
reviewed
Dec 19, 2024
| @@ -346,8 +346,11 @@ ldmsd_stream_subscribe(const char *stream_name, | |||
| } | |||
| LIST_FOREACH(cc, &s->s_c_list, c_ent) { | |||
| if (cc->c_cb_fn == cb_fn && cc->c_ctxt == ctxt) { | |||
| #if 0 | |||
| /* this is a high frequency common case */ | |||
There was a problem hiding this comment.
This looks like we're hiding a configuration error and it has nothing to do with this fix.
tom95858
reviewed
Dec 19, 2024
| @@ -246,6 +246,7 @@ static void fclose_and_spool(FILE* *f, char* *fname, int final) | |||
| sprintf(rbuf, "%s/spool/%s", dirn, base); | |||
| err = rename(*fname, rbuf); | |||
| if (err) { | |||
| err = errno; | |||
There was a problem hiding this comment.
This code doesn't do anything. The function returns void.
There was a problem hiding this comment.
@baallan, ok I see that you're setting it so that the error message is correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix errno misreported in blobwriter, and stop warning about repeat subscribe, which happens a lot (50000 out of 55000 log lines in a recent case)