-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix for updater parsing #1581
Conversation
Is the intention for an updaters stanza of:
to result in configuration lines like:
Just want to confirm that this is expected. I am adding no |
Hey @emdonat, this is the intended behavior. Otherwise we'd have to reverse engineer a regular expression from the list of producer names. |
Just to confirm - each updtr_prdcr_add on the same name=updtr_0 appends rather than overwrites the prior? I just want to make sure that the end result isn't that the only regex is the final one processed e.g. compute30-ib0. |
@emdonat, match_add appends to a list of match expressions. They. are all evaluated to determine if there is a match. You can view this list in the ldmsd_controller using the updtr_match_list command. |
Yes, that's correct. Subsequent updtr_prdcr_add calls do not overwrite previous calls |
This is prdcr_add in this case. |
Thanks. I think that this actually helps with some functionality that was hoped for when demoing this yesterday. Forging our own limiting regex was going to be a frustrating ordeal and error prone. |
Addresses bug when "updaters" is omitted from "peers" dictionary in top level "aggregators" dictionary. Fixes bug that occurs when "producers" regular expression is not defined in the "updaters" dictionary. Updaters now correctly only add the parent dictionary's producers when "produers" is not defined in the updaters dictionary. Updated producer balancing when multiple aggregators share producers in the YAML configuration.
676eb7e
to
c3e2996
Compare
Added a missing newline when using a string for configuration commands in the top level |
Addresses bug when "updaters" is omitted from "peers" dictionary in top level "aggregators" dictionary.
Fixes bug that occurs when "producers" regular expression is not defined in the "updaters" dictionary.
Updaters now correctly only add the parent dictionary's producers when "produers" is not defined in the updaters dictionary.
Updated producer balancing when multiple aggregators share producers in the YAML configuration.
Updated ldmsd_yaml_parser man page