Add a section in the README on how to fix line break encoding issue #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminelouati
reviewed
Sep 1, 2020
| `The file will have its original line endings in your working directory | ||
| warning: LF will be replaced by CRLF in ...` can appear for each file having an issue. | ||
|
|
||
| To fix the problem the encoding must be consistent in automation-dashboard and all the sub-projects. We will use Dos2Unix tool To achieve that. |
There was a problem hiding this comment.
To fix this issue, the encoding has to be consistent in automation-dashboard including all its sub-projects
amouhoub
reviewed
Sep 1, 2020
| @@ -112,6 +112,26 @@ Then build automation-dashboard, that will compose all subviews. | |||
|
|
|||
| In order to test subviews and automation dashboard locally, it is required not to publish the subviews archives to main repository, but to local repository of machine. | |||
|
|
|||
| ### Line break issue: | |||
| If you are building automation dashboard or subviews using different OS over time you can face an encoding issue. It usually manifest with | |||
There was a problem hiding this comment.
Please make sure to mention that it occurs particularly on Windows as it never occurred before on linux or Mac. It will probably never occur on Linux because you cannot merge it if on this repo because Jenkins compilations will fail.
|
Thanks for your comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.