Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure integration #118

Closed
wants to merge 16 commits into from
Closed

Azure integration #118

wants to merge 16 commits into from

Conversation

mbenguig
Copy link
Member

No description provided.

Copy link
Member

@ankicabarisic ankicabarisic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please resolve the conflicts with reconfiguration and write what was fixed by this PR and how it can be tested

@fviale
Copy link
Member

fviale commented Dec 27, 2024

@mbenguig
This is a lot of commits, are you sure your fork is synced with the master repository ?

As a side note, I had a lot of issues with cherry-picking this project when releasing 14.0.2 . Please ensure that when merging pull requests commits are squashed. If there are too many commits and squash is too complicated, just do a clean fork and clean pull request

Copy link

sonarqubecloud bot commented Jan 3, 2025

@fviale
Copy link
Member

fviale commented Jan 3, 2025

@mbenguig your pull request has too many commits and your fork is not properly synchronized with the master.

Please do a clean fork and clean pull request

You can obtain this pull request diff by using:
https://patch-diff.githubusercontent.com/raw/ow2-proactive/scheduling-abstraction-layer/pull/118.diff

@mbenguig
Copy link
Member Author

mbenguig commented Jan 3, 2025

please resolve the conflicts with reconfiguration and write what was fixed by this PR and how it can be tested

Resolved

@ankicabarisic
Copy link
Member

testing and problems i reported on slack
i would prefer that you create new branch from master, and apply your changes there as it is only several lines of code in SAL and see how it behaves then
when i pull this branch it is not having latest changes on master branch so it might impact the different behaviour then the one you are having, also the failing deleteCluster might be due to fact the changes from begining of december are not there

@@ -255,26 +257,40 @@ private String createIAASNodeConfigJson(Task task, Deployment deployment) {
imageId = deployment.getNode().getNodeCandidate().getLocation().getName() + "/" +
deployment.getNode().getNodeCandidate().getImage().getProviderId();
}
break;
case OPENSTACK:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you delete openstack here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openstack and default branches are equivalent but ok to re-add the openstack branch

@mbenguig
Copy link
Member Author

mbenguig commented Jan 4, 2025

Will be replaced by another PR.

@mbenguig mbenguig closed this Jan 4, 2025
@mbenguig mbenguig deleted the azure-integration branch January 4, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants