-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure integration #118
Azure integration #118
Conversation
…ion-layer into azure-integration
…ng-abstraction-layer into azure-integration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please resolve the conflicts with reconfiguration and write what was fixed by this PR and how it can be tested
@mbenguig As a side note, I had a lot of issues with cherry-picking this project when releasing 14.0.2 . Please ensure that when merging pull requests commits are squashed. If there are too many commits and squash is too complicated, just do a clean fork and clean pull request |
Quality Gate passedIssues Measures |
@mbenguig your pull request has too many commits and your fork is not properly synchronized with the master. Please do a clean fork and clean pull request You can obtain this pull request diff by using: |
Resolved |
testing and problems i reported on slack |
@@ -255,26 +257,40 @@ private String createIAASNodeConfigJson(Task task, Deployment deployment) { | |||
imageId = deployment.getNode().getNodeCandidate().getLocation().getName() + "/" + | |||
deployment.getNode().getNodeCandidate().getImage().getProviderId(); | |||
} | |||
break; | |||
case OPENSTACK: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you delete openstack here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
openstack and default branches are equivalent but ok to re-add the openstack branch
Will be replaced by another PR. |
No description provided.