Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix phase 2 and 3 audit logging in case of internal redirect #255

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix phase 2 and 3 audit logging in case of internal redirect #255

wants to merge 2 commits into from

Commits on Jun 3, 2024

  1. Tests: Add test cases for all phases in custom error page test

    @mlevogiannis
    mlevogiannis committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    d90eed5 View commit details
    Browse the repository at this point in the history

  2. Fix phase 2 and 3 audit logging in case of internal redirect 

    Phase 2 and 3 log entries were not logged in the audit log in case of an
internal redirect. Only phase 1 and 4 ones were logged, the former because
early logging was explicitly enabled and the latter because the internal
redirect does not work in this phase.

This commit unconditionally enables early logging in all ModSecurity
phases. Since the Nginx log phase may not be executed in case of an
intervention, the process intervention function is the only place which is
guaranteed to call the log handler in such a case.

Co-authored-by: Dimitris Kolotouros <[email protected]>
Co-authored-by: Thanos Giannopoulos <[email protected]>
    @mlevogiannis @kolotouros @thanosgn
    3 people committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    02249da View commit details
    Browse the repository at this point in the history