Fix ActiveRecord deprecations from Rails 6.1 #1076

texpert · 2024-07-25T17:37:46Z

There are several deprecation warnings on CI on Rails 6.1. This PR is fixing the issues.

In PostDefault: Fix "Deprecate .reorder(nil) with .first / .first! taking non-deterministic result" message - see Deprecate .reorder(nil) with .first / .first! taking non-deterministic result rails/rails#36889
in CustomFieldGroup: Fix Deprecation warning in 6.1 if a default_scope contains a where.not - see Deprecation warning in 6.1 if a default_scope contains a where.not rails/rails#42759
Remove deprecated associations from the custom_fields_read mixin, do some micro-optimizations of the code

…nistic result" message - see rails/rails#36889

…some micro-optimizations of the code

[skip ci]

texpert requested review from owen2345 and brian-kephart July 25, 2024 17:51

owen2345 approved these changes Jul 26, 2024

View reviewed changes

texpert added 5 commits July 26, 2024 16:04

Fix "Deprecate .reorder(nil) with .first / .first! taking non-determi…

61e8c6f

…nistic result" message - see rails/rails#36889

Fix Deprecation warning in 6.1 if a default_scope contains a where.no…

772e65c

…t - see rails/rails#42759

Remove deprecated associations from the custom_fields_read mixin, do …

36b323d

…some micro-optimizations of the code

Fix rubocop issue

2c58fb0

Add the changelog entry

3aed50b

[skip ci]

texpert force-pushed the fix-active-record-deprecations branch from 5510ce3 to 3aed50b Compare July 26, 2024 13:20

texpert merged commit 53cdef5 into owen2345:master Jul 26, 2024

texpert deleted the fix-active-record-deprecations branch August 21, 2024 17:45

Provide feedback