Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 use markdown for rendering grouped text wraps / TAS-782 #4402

Draft
wants to merge 1 commit into
base: scatter-axis-labels-viz
Choose a base branch
from

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Jan 8, 2025

Gets rid of TextWrapGroup and instead uses the MarkdownTextWrap component to implement similar behaviour.

Note

To do: Check SVG tester once its parent PR is merged


This is part 2 of 3 in a stack made with GitButler:

@sophiamersmann sophiamersmann changed the title 🔨 use markdown for rendering grouped text wraps 🔨 use markdown for rendering grouped text wraps / TAS-782 Jan 8, 2025
Copy link

Simplify TextWrapGroup

@owidbot
Copy link
Contributor

owidbot commented Jan 8, 2025

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-markdown-text-wrap-group

SVG tester:

Number of differences (default views): 577 (784fb3) ❌
Number of differences (all views): 403 (42a494) ❌

Edited: 2025-01-09 15:36:32 UTC
Execution time: 1.34 seconds

@sophiamersmann sophiamersmann force-pushed the scatter-axis-labels-viz branch from 84e6485 to 0f6ed49 Compare January 9, 2025 11:59
@sophiamersmann sophiamersmann force-pushed the markdown-text-wrap-group branch from 7a1dd77 to 8ce1f76 Compare January 9, 2025 11:59
@sophiamersmann sophiamersmann force-pushed the scatter-axis-labels-viz branch from 0f6ed49 to d95a8ab Compare January 9, 2025 12:52
@sophiamersmann sophiamersmann force-pushed the markdown-text-wrap-group branch from 8ce1f76 to 54f3e88 Compare January 9, 2025 12:52
@sophiamersmann sophiamersmann force-pushed the scatter-axis-labels-viz branch from d95a8ab to 721caf1 Compare January 9, 2025 15:09
@sophiamersmann sophiamersmann force-pushed the markdown-text-wrap-group branch from 54f3e88 to ea07fb3 Compare January 9, 2025 15:09
@sophiamersmann sophiamersmann added the staging-viz Let SVG tester fail silently in CI label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staging-viz Let SVG tester fail silently in CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants