Skip to content

Refactor/image on entity #287

Refactor/image on entity

Refactor/image on entity #287

Triggered via pull request October 17, 2023 13:54
Status Failure
Total duration 2m 22s
Artifacts

phpstan.yml

on: pull_request
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

8 errors
PHP 8.2: app/Http/Controllers/Api/v1/DefaultThumbnailApiController.php#L34
Method App\Http\Controllers\Api\v1\DefaultThumbnailApiController::upload() should return App\Http\Resources\EntityDefaultThumbnailResource but returns Illuminate\Http\JsonResponse.
PHP 8.2: app/Http/Controllers/Api/v1/DefaultThumbnailApiController.php#L42
Method App\Http\Controllers\Api\v1\DefaultThumbnailApiController::upload() should return App\Http\Resources\EntityDefaultThumbnailResource but returns Illuminate\Http\JsonResponse.
PHP 8.2: app/Http/Controllers/Api/v1/DefaultThumbnailApiController.php#L47
Method App\Http\Controllers\Api\v1\DefaultThumbnailApiController::upload() should return App\Http\Resources\EntityDefaultThumbnailResource but returns Illuminate\Http\JsonResponse.
PHP 8.2: app/Http/Controllers/Api/v1/DefaultThumbnailApiController.php#L55
PHPDoc tag @param for parameter $request with type App\Http\Controllers\Api\v1\Request is not subtype of native type App\Http\Requests\Campaigns\DestroyDefaultThumbnail.
PHP 8.2: app/Http/Controllers/Api/v1/DefaultThumbnailApiController.php#L55
Parameter $request of method App\Http\Controllers\Api\v1\DefaultThumbnailApiController::delete() has invalid type App\Http\Controllers\Api\v1\Request.
PHP 8.2: app/Http/Controllers/Api/v1/EntityImageApiController.php#L20
Expression "$entity->child" on a separate line does not do anything.
PHP 8.2: app/Http/Resources/EntityResource.php#L160
No error to ignore is reported on line 160.
PHP 8.2
Process completed with exit code 1.